-
Notifications
You must be signed in to change notification settings - Fork 83
[SDK-131] Fix CI for business critical integration #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #986 +/- ##
==========================================
+ Coverage 69.26% 69.38% +0.12%
==========================================
Files 109 109
Lines 8917 8917
==========================================
+ Hits 6176 6187 +11
+ Misses 2741 2730 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // Use coordinate tap to avoid scroll issues in CI | ||
| if checkMessagesButton.isHittable { | ||
| checkMessagesButton.tap() | ||
| } else { | ||
| checkMessagesButton.coordinate(withNormalizedOffset: CGVector(dx: 0.5, dy: 0.5)).tap() | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat!
| CLEANUP=true | ||
| TIMEOUT=60 | ||
| FAST_TEST=false | ||
| OPEN_SIMULATOR=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this the root cause for the webview issues? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this was just for testing
Summary
Fixes CI failures in business-critical integration tests by addressing timing issues, navigation retry logic, and a time-of-day dependent bug.
Changes Made
1. Fixed Time-of-Day Dependent Test Bug (IntegrationTestBase)
BEGINSWITH '4' OR BEGINSWITH '5'predicate^[45][0-9]{2}$to only match 3-digit HTTP status codes (400, 401, 500, etc.)2. Added Network Monitor Retry Logic (InAppMessageIntegrationTests & IntegrationTestBase)
3. Added Coordinate-Based Tap for Check Messages Button
4. Removed Redundant Custom Action Test
5. Added --open Flag to run-tests.sh
Root Cause Analysis
Time-of-Day Test Failure (NEW FIX):
verifyNetworkCallWithSuccessfunction checked for error status codes usingBEGINSWITH '4' OR BEGINSWITH '5'BEGINSWITH '4'causing false positiveNetwork Monitor Navigation Failure:
Custom Action Test Timeout:
Test Coverage
All core functionality remains fully tested:
Testing