-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-10402] Fix Tests #876
base: master
Are you sure you want to change the base?
Conversation
@sumeruchat should we remove the other changes other than the part that add the report? |
@joaodordio Yeah sure I can undo those but those make sense rite? Should i add that in a seperate PR? |
absolutely, I've added those here: #872 |
yeah once you merge your branch i will rebase |
3bb2f30
to
7b8e280
Compare
@joaodordio @evantk91 @Ayyanchira Please note that the following tests are disabled
|
Some of these seem rather important to be skipping right? They also look like simple tests — meaning they shouldn't be failing right? Do we know what's behind the failure before we commit to skipping them? Also, should we remove the codecov.io step? We are not using that anymore. |
Yes Code cov may be worked on when working on reporting tools. But I agree its important to document why those are failing before skipping them |
I fixed some more tests the final list of skipped tests is now From unit-tests: |
Lets look at code coverage in the CI reporting task. Here lets focus on fixing tests. It would be awesome if you guys can help fixing the remaining tests. @Ayyanchira @joaodordio @evantk91 |
🔹 Jira Ticket(s)
✏️ Description
Add nice reports for tests
Example https://github.com/Iterable/iterable-swift-sdk/actions/runs/12316457995