Skip to content

Fixing Codecov file structure to alignment #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: MOB-10999-Reporting-tool
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ codecov:
coverage:
precision: 2
round: down
range: "70...100"
range: "50...100"
status:
project:
default:
Expand Down Expand Up @@ -45,6 +45,9 @@ flags:
iterableapi-ui:
paths:
- iterableapi-ui/src/main/
app:
paths:
- app/src/main/

comment:
layout: "reach,diff,flags,files,footer"
Expand Down
19 changes: 10 additions & 9 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,17 @@ jobs:
- run: touch local.properties

- name: Test
run: ./gradlew :iterableapi:jacocoTestDebugUnitTestReport :iterableapi-ui:jacocoTestDebugUnitTestReport :app:jacocoDebugTestReport
run: |
./gradlew :iterableapi:jacocoTestDebugUnitTestReport :iterableapi-ui:jacocoTestDebugUnitTestReport :app:jacocoDebugTestReport
find . -name "*.xml" -path "*/build/reports/jacoco/*"

- name: Upload coverage data
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
with:
name: unit-tests
path: |
./**/build/**/jacoco*.xml
./**/build/**/report.xml
./**/build/reports/jacoco/**/*.xml
./**/build/reports/coverage/**/*.xml

instrumentation-tests:
name: Instrumentation tests
Expand Down Expand Up @@ -97,7 +99,7 @@ jobs:
runs-on: ubuntu-latest
needs: [unit-tests, instrumentation-tests]
env:
JACOCO_SOURCE_PATH: "iterableapi/src/main/java iterableapi-ui/src/main/java"
JACOCO_SOURCE_PATH: "iterableapi/src/main/java iterableapi-ui/src/main/java app/src/main/java"
steps:
- name: Checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand Down Expand Up @@ -125,18 +127,17 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: |
./iterableapi/build/reports/jacoco/jacocoTestDebugUnitTestReport/jacocoTestDebugUnitTestReport.xml,
./iterableapi-ui/build/reports/jacoco/jacocoTestDebugUnitTestReport/jacocoTestDebugUnitTestReport.xml,
./app/build/reports/jacoco/jacocoDebugTestReport/jacocoDebugTestReport.xml,
./iterableapi/build/reports/coverage/androidTest/debug/connected/report.xml
./**/build/reports/jacoco/**/*.xml,
./**/build/reports/coverage/**/*.xml
fail_ci_if_error: false
verbose: true

# Fallback using bash uploader with explicit token
- name: Upload to Codecov via bash uploader
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: bash <(curl -s https://codecov.io/bash) -v
run: |
bash <(curl -s https://codecov.io/bash) -v -s "**/build/reports/jacoco/" -s "**/build/reports/coverage/"

- uses: actions/cache@v3
with:
Expand Down
74 changes: 19 additions & 55 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -109,62 +109,26 @@ task jacocoDebugTestReport(type: JacocoReport, dependsOn: ['testDebugUnitTest'])
'**/*$ViewInjector*.class',
]

def debugTree = fileTree(dir: "${buildDir}/intermediates/javac/debug/classes", excludes: fileFilter) //we use "debug" build type for test coverage (can be other)
def sdkTree = fileTree(dir: "${buildDir}/../../iterableapi/build/intermediates/javac/debug/classes", excludes: fileFilter)
def sdkUiTree = fileTree(dir: "${buildDir}/../../iterableapi-ui/build/intermediates/javac/debug/classes", excludes: fileFilter)
def debugTree = fileTree(dir: "${buildDir}/intermediates/javac/debug/classes", excludes: fileFilter)
def kotlinDebugTree = fileTree(dir: "${buildDir}/tmp/kotlin-classes/debug", excludes: fileFilter)
def mainSrc = "${project.projectDir}/src/main/java"
def sdkSrc = "${project.projectDir}/../iterableapi/src/main/java"
def sdkUiSrc = "${project.projectDir}/../iterableapi-ui/src/main/java"

sourceDirectories.from = files([mainSrc])
classDirectories.from = files([debugTree])
additionalSourceDirs.from = files([sdkSrc, sdkUiSrc])
additionalClassDirs.from = files([sdkTree, sdkUiTree])
executionData.from = fileTree(dir: "$buildDir", includes: [
"jacoco/testDebugUnitTest.exec"
])
}

task jacocoDebugAndroidTestReport(type: JacocoReport, dependsOn: ['connectedCheck']) {
group = "reporting"
description = "Generate Jacoco code coverage report for instumentation tests"

reports {
xml.required = true
html.required = true
csv.required = false
def mainKotlinSrc = "${project.projectDir}/src/main/kotlin"

sourceDirectories.setFrom(files([mainSrc, mainKotlinSrc]))
classDirectories.setFrom(files([debugTree, kotlinDebugTree]))

// Only include unit test execution data by default
def execData = fileTree(dir: "$buildDir", includes: ["jacoco/testDebugUnitTest.exec"])

// Add instrumentation test data if available
def instrumentationData = fileTree(dir: "$buildDir", includes: ["outputs/code_coverage/debugAndroidTest/connected/**/coverage.ec"])
if (instrumentationData.files.size() > 0) {
execData.include(instrumentationData.includes)
}

executionData.setFrom(execData)
}

def fileFilter = [
'**/*Test*.*',
'**/AutoValue_*.*',
'**/*JavascriptBridge.class',
'**/R.class',
'**/R$*.class',
'**/Manifest*.*',
'android/**/*.*',
'**/BuildConfig.*',
'**/*$ViewBinder*.*',
'**/*$ViewInjector*.*',
'**/Lambda$*.class',
'**/Lambda.class',
'**/*Lambda.class',
'**/*Lambda*.class',
'**/*$InjectAdapter.class',
'**/*$ModuleAdapter.class',
'**/*$ViewInjector*.class',
]

def debugTree = fileTree(dir: "${buildDir}/intermediates/javac/debug/classes", excludes: fileFilter) //we use "debug" build type for test coverage (can be other)
def sdkTree = fileTree(dir: "${buildDir}/../../iterableapi/build/intermediates/javac/debug/classes", excludes: fileFilter)
def sdkUiTree = fileTree(dir: "${buildDir}/../../iterableapi-ui/build/intermediates/javac/debug/classes", excludes: fileFilter)
def mainSrc = "${project.projectDir}/src/main/java"
def sdkSrc = "${project.projectDir}/../iterableapi/src/main/java"
def sdkUiSrc = "${project.projectDir}/../iterableapi-ui/src/main/java"

sourceDirectories.from = files([mainSrc])
classDirectories.from = files([debugTree])
additionalSourceDirs.from = files([sdkSrc, sdkUiSrc])
additionalClassDirs.from = files([sdkTree, sdkUiTree])
executionData.from = fileTree(dir: "$buildDir", include: "outputs/code_coverage/debugAndroidTest/connected/**/*.ec")
tasks.matching { it.name.contains('jacocoDebugAndroidTestReport') }.all { task ->
task.enabled = false
}
21 changes: 15 additions & 6 deletions iterableapi-ui/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,19 @@ task jacocoTestDebugUnitTestReport(type: JacocoReport, dependsOn: ['testDebugUni
def debugTree = fileTree(dir: "${buildDir}/intermediates/javac/debug/classes", excludes: fileFilter)
def kotlinDebugTree = fileTree(dir: "${buildDir}/tmp/kotlin-classes/debug", excludes: fileFilter)
def mainSrc = "${project.projectDir}/src/main/java"

sourceDirectories.from = files([mainSrc])
classDirectories.from = files([debugTree, kotlinDebugTree])
executionData.from = fileTree(dir: "$buildDir", includes: [
"jacoco/testDebugUnitTest.exec"
])
def mainKotlinSrc = "${project.projectDir}/src/main/kotlin"

sourceDirectories.setFrom(files([mainSrc, mainKotlinSrc]))
classDirectories.setFrom(files([debugTree, kotlinDebugTree]))

// Only include unit test execution data by default
def execData = fileTree(dir: "$buildDir", includes: ["jacoco/testDebugUnitTest.exec"])

// Add instrumentation test data if available
def instrumentationData = fileTree(dir: "$buildDir", includes: ["outputs/code_coverage/debugAndroidTest/connected/**/coverage.ec"])
if (instrumentationData.files.size() > 0) {
execData.include(instrumentationData.includes)
}

executionData.setFrom(execData)
}
21 changes: 15 additions & 6 deletions iterableapi/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,19 @@ task jacocoTestDebugUnitTestReport(type: JacocoReport, dependsOn: ['testDebugUni
def debugTree = fileTree(dir: "${buildDir}/intermediates/javac/debug/classes", excludes: fileFilter)
def kotlinDebugTree = fileTree(dir: "${buildDir}/tmp/kotlin-classes/debug", excludes: fileFilter)
def mainSrc = "${project.projectDir}/src/main/java"

sourceDirectories.from = files([mainSrc])
classDirectories.from = files([debugTree, kotlinDebugTree])
executionData.from = fileTree(dir: "$buildDir", includes: [
"jacoco/testDebugUnitTest.exec"
])
def mainKotlinSrc = "${project.projectDir}/src/main/kotlin"

sourceDirectories.setFrom(files([mainSrc, mainKotlinSrc]))
classDirectories.setFrom(files([debugTree, kotlinDebugTree]))

// Only include unit test execution data by default
def execData = fileTree(dir: "$buildDir", includes: ["jacoco/testDebugUnitTest.exec"])

// Add instrumentation test data if available
def instrumentationData = fileTree(dir: "$buildDir", includes: ["outputs/code_coverage/debugAndroidTest/connected/**/coverage.ec"])
if (instrumentationData.files.size() > 0) {
execData.include(instrumentationData.includes)
}

executionData.setFrom(execData)
}
Loading