Clone parity: add http and ssh network source coverage#29
Merged
Conversation
Expand clone parity coverage to http and https and ssh sources while preserving branch depth filter and recurse-submodules semantics and receive-pack parity gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Repo.cloneacceptshttpandhttpsandsshsources while preserving branch and depth and filter and recurse-submodules option behavior.INV-FEAT-0053includes local and file and http and https and ssh source coverage.Checklist
scripts/checkandscripts/parity_matrix_checktokens for widened parity gates.node scripts/check --runtime=nodesuccessfully.Simulated Role Reviews
Product review
Findings:
Changes made:
httpandhttpsandsshclone source handling with branch and depth and filter and recurse-submodules option support.Evidence pointers:
src/index.tsdocs/api.mdQA review
Findings:
INV-FEAT-0053evidence lacked explicit tests for network clone sources.Changes made:
Evidence pointers:
tests/node/clone-receive-pack.test.mjsnode scripts/check --runtime=nodeSecurity review
Findings:
Changes made:
Evidence pointers:
src/index.tstests/node/clone-receive-pack.test.mjsPerformance review
Findings:
Changes made:
scripts/checkandscripts/parity_matrix_checkfor network source tokens.Evidence pointers:
scripts/checkscripts/parity_matrix_checkMaintainer review
Findings:
Changes made:
docs/parity-matrix.mdandspec/invariants.yamlanddocs/api.mdto cover local and file and http and https and ssh sources.Evidence pointers:
docs/parity-matrix.mdspec/invariants.yamldocs/api.md