Implement clone and receive-pack plumbing parity slice#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Repo.cloneMUST materialize the selected branch tree and matchgit clone --branchhead/worktree parity for local sources.Checklist
Repo.clonewith local branch selection and unsupported-option guards for depth/filter/submodules.receivePackRequest,receivePackAdvertiseRefs, andreceivePackUpdateAPI methods.src/core/network/receive-pack.tspkt-line helpers.docs/api.md,docs/parity-matrix.md, andspec/parity-roadmap.yaml.node scripts/check --runtime=nodesuccessfully.Simulated Role Reviews
Product review
Findings:
Changes made:
src/index.ts.src/index.tswith lock-guarded update behavior.Evidence pointers:
tests/node/clone-receive-pack.test.mjsdocs/api.mdQA review
Findings:
Changes made:
clone local branch selection keeps parity with git clone INV-FEAT-0053test.receive-pack plumbing builds pkt-lines and applies guarded ref updates INV-FEAT-0053test.Evidence pointers:
tests/node/clone-receive-pack.test.mjsnode scripts/check --runtime=nodeSecurity review
Findings:
Changes made:
LOCK_CONFLICTfor stale updates.Evidence pointers:
src/index.tssrc/core/network/receive-pack.tsPerformance review
Findings:
Changes made:
Evidence pointers:
src/core/network/receive-pack.tssrc/index.tsMaintainer review
Findings:
Changes made:
src/core/network/receive-pack.tsand wired imports.Evidence pointers:
docs/parity-matrix.mdspec/parity-roadmap.yaml