feat: implement backfill command-family parity#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Checklist
spec/state.yamlremains at the active phase value18.node scripts/checkexits with code0for node and deno and bun runtimes.artifacts/gatesand referenced below.Simulated Role Reviews
Product review
Findings:
backfillnow maps to executable evidence instead of a placeholder state.Changes made:
src/core/backfill/backfill.ts.Repo.backfillsemantics and promisor normalization insrc/index.tsandsrc/core/partial-clone/promisor.ts.docs/parity-matrix.md,spec/parity-roadmap.yaml, anddocs/api.md.Evidence pointers:
tests/node/backfill.test.mjscontains option-status and sparse-scope parity assertions.scripts/parity_matrix_checknow enforces backfill evidence requirements.artifacts/gates/INV-FEAT-0044.jsonandartifacts/gates/INV-SECU-0016.jsonare present.QA review
Findings:
Changes made:
tests/node/backfill.test.mjswith CLI baseline comparisons and hydration-flow coverage.Evidence pointers:
node scripts/check --runtime=node,node scripts/check --runtime=deno,node scripts/check --runtime=bun.tests/node/backfill.test.mjs.scripts/parity_matrix_check.Security review
Findings:
minBatchSizevalues throughINVALID_ARGUMENT.Changes made:
src/core/backfill/backfill.ts.src/index.tsandsrc/core/partial-clone/promisor.ts.Evidence pointers:
tests/node/backfill.test.mjsinvalid option assertion.tests/node/sparse-partial-clone.test.mjsintegrity error coverage remains active.artifacts/gates/INV-SECU-0016.jsonis present.Performance review
Findings:
Changes made:
src/index.ts.Evidence pointers:
src/index.tsbackfill selection and min-batch-size logic.tests/node/backfill.test.mjssparse and threshold scenarios.node scripts/check --runtime=node.Maintainer review
Findings:
docs/api.mdwith machine-verifiable enforcement in parity checks.Changes made:
docs/api.mdwith explicit backfill semantics.docs/parity-matrix.mdandspec/parity-roadmap.yamlto implemented state.scripts/parity_matrix_checkto require backfill API and evidence test coverage.Evidence pointers:
docs/api.md,docs/parity-matrix.md,spec/parity-roadmap.yaml.scripts/parity_matrix_checkandtests/node/backfill.test.mjs.artifacts/gates/INV-FEAT-0052.jsonis present.