feat: implement repo command-family parity#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Repo.repoInfo()parity forgit repo info --format=keyvalueoutputs.Repo.repoStructure()parity forgit repo structure --format=keyvalueoutputs.repocommand family as implemented in roadmap and parity matrix.repoinscripts/parity_matrix_check.Checklist
node scripts/check --runtime=nodenode scripts/check --runtime=denonode scripts/check --runtime=bunnpx jsr publish --dry-run --allow-dirty --config jsr.jsonSimulated Role Reviews
Product review
Findings:
last-modifiedwasrepocommand family coverage.Changes made:
repoInfoandrepoStructureAPI operations.repo.Evidence pointers:
src/index.tsdocs/parity-matrix.mdspec/parity-roadmap.yamlQA review
Findings:
reposubcommands.Changes made:
git repo info --format=keyvalueparity.git repo structure --format=keyvalueparity.Evidence pointers:
tests/node/repo-command-family.test.mjsSecurity review
Findings:
srcruntime policy disallows process spawning in production code.Changes made:
Evidence pointers:
src/index.tssrc/core/repo/repo-command.tsPerformance review
Findings:
Changes made:
seenset to avoid duplicate object parsing.Evidence pointers:
src/index.tsMaintainer review
Findings:
Changes made:
repoevidence assertions toscripts/parity_matrix_check.Evidence pointers:
scripts/parity_matrix_checkdocs/api.mddocs/parity-matrix.mdspec/parity-roadmap.yaml