Revert #574 to restore green main#584
Merged
Merged
Conversation
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #574 to restore a green main
Why: #574 ("feat: emergency pause, milestone withdrawals, and per-campaign tokens") was merged on 2026-07-01 while its own CI was red, and it does not compile. main has been broken ever since, which is why every open stellar PR shows the same errors (fmt/clippy/test) — they all rebase/merge onto a broken main.
The breakage in #574:
set_emergency_pause_signersimport vs the local fn (E0255)token_client_for_address(E0106)Vec::iter_mutinverify_milestone(unsupported by soroban Vec, E0599)s == &callertype mismatch inemergency_pause(E0308)Vec,token_client,set_emergency_pause_signers(fail-D warnings)token/uses_milestonesfields on bothCreateCampaignParamsandCampaign(E0063)token: Option<Address>in a#[contracttype]struct is not ScVal-convertible in the pinned soroban-sdk — this one is a real data-model issue, not mechanical.This revert restores the last green commit (368b0f6). The feature should be re-submitted as a fresh PR with passing CI (the
Option<Address>representation needs rethinking so it satisfies#[contracttype]).cc @logantalen — happy to help get the re-submit green.