test: add multi-step transaction sequence test#582
Open
TheShnider wants to merge 5 commits into
Open
Conversation
|
@TheShnider Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
davidmaronio
requested changes
Jul 4, 2026
davidmaronio
left a comment
Contributor
There was a problem hiding this comment.
this is titled/issue-linked as "add a test" but the diff does a lot more, and a couple of things block it:
- it commits a stray helper script fix_tests.py to the repo root (regex text-munging, build cruft). remove it.
- the actual new test in src/tests/test_multi_step.rs only does create_campaign then cancel_campaign. that is not a multi-step transaction sequence (no contribute/withdraw/refund), so it does not exercise what the title implies. please make it a real sequence.
- it rewrites types.rs (new MaybeAddress enum, CreateCampaignParams.token changed from Option), admin.rs verify_milestone, campaigns/create.rs etc. none of that belongs in a test PR and it collides with #575/#578. drop the unrelated changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Provide a clear and concise description of the changes in this PR.
🔗 Related Issues
Use GitHub's auto-close keywords with the
#prefix (one issue per line):Closes #532
Multiple issues can be closed by repeating the keyword on separate lines.
🧪 Changes Made
✅ Checklist
If this PR introduces breaking changes, describe them here.
📸 Screenshots (if applicable)
Add screenshots to help reviewers understand the changes.
🧩 Additional Notes
Anything else reviewers should know.