Skip to content

test: add multi-step transaction sequence test#582

Open
TheShnider wants to merge 5 commits into
Iris-IV:mainfrom
TheShnider:fix/auth-scope-audit
Open

test: add multi-step transaction sequence test#582
TheShnider wants to merge 5 commits into
Iris-IV:mainfrom
TheShnider:fix/auth-scope-audit

Conversation

@TheShnider

Copy link
Copy Markdown

📌 Description

Provide a clear and concise description of the changes in this PR.

🔗 Related Issues

Use GitHub's auto-close keywords with the # prefix (one issue per line):

Closes #532

Multiple issues can be closed by repeating the keyword on separate lines.

🧪 Changes Made

  • Bug fix
  • New feature
  • Refactor
  • Documentation update

✅ Checklist

  • Code compiles successfully
  • Tests added/updated and passing
  • Linting passes (no warnings/errors)
  • Documentation updated (if required)
  • No breaking changes (or clearly documented)

⚠️ Breaking Changes

If this PR introduces breaking changes, describe them here.

📸 Screenshots (if applicable)

Add screenshots to help reviewers understand the changes.

🧩 Additional Notes

Anything else reviewers should know.

@drips-wave

drips-wave Bot commented Jul 2, 2026

Copy link
Copy Markdown

@TheShnider Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@davidmaronio davidmaronio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is titled/issue-linked as "add a test" but the diff does a lot more, and a couple of things block it:

  1. it commits a stray helper script fix_tests.py to the repo root (regex text-munging, build cruft). remove it.
  2. the actual new test in src/tests/test_multi_step.rs only does create_campaign then cancel_campaign. that is not a multi-step transaction sequence (no contribute/withdraw/refund), so it does not exercise what the title implies. please make it a real sequence.
  3. it rewrites types.rs (new MaybeAddress enum, CreateCampaignParams.token changed from Option), admin.rs verify_milestone, campaigns/create.rs etc. none of that belongs in a test PR and it collides with #575/#578. drop the unrelated changes.

@TheShnider TheShnider requested a review from davidmaronio July 6, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Soroban authorization model: require_auth() called on wrong scope — nested auth token can be consumed by wrong function

2 participants