Fix #556: Automatically revoke verification upon description update#579
Fix #556: Automatically revoke verification upon description update#579Banx17 wants to merge 3 commits into
Conversation
|
@Banx17 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
davidmaronio
left a comment
There was a problem hiding this comment.
the description-update auto-revoke logic is correct (clears is_verified + decrement_verified_campaign_count with an underflow guard, and the test checks it), good. same scope issue as your #580 though, it's branched off the #581 milestone branch and carries ~20 files of that feature, please rebase onto clean main so it's just the description/verification change. fix the u32->u32 unnecessary cast (clippy) + cargo fmt. also this overlaps stellar #573 which does the same auto-revoke, you two should reconcile so only one lands.
Overview
This PR addresses issue #556 by automatically revoking campaign verification when the description is updated significantly. This ensures that verified content remains accurate and any major changes require re-verification by the community or admin.
Changes
update_campaign_descriptioninsrc/campaigns/update.rsto setcampaign.is_verified = falseif the campaign is currently verified.decrement_verified_campaign_countinsrc/storage.rsto properly decrement the platform stats counter.test_campaign_update_description_successto verify verification revocation.Verification
[npm run lint ✅ completed (existing repo warnings only)
npm run typecheck ✅ passed
npm test -- src/config/tests/config.test.ts --runInBand ✅ passed (9/9)
npm run build ✅ passed]
Fixes #556