Skip to content

Fix #556: Automatically revoke verification upon description update#579

Open
Banx17 wants to merge 3 commits into
Iris-IV:mainfrom
Banx17:fix-issue-556
Open

Fix #556: Automatically revoke verification upon description update#579
Banx17 wants to merge 3 commits into
Iris-IV:mainfrom
Banx17:fix-issue-556

Conversation

@Banx17

@Banx17 Banx17 commented Jul 2, 2026

Copy link
Copy Markdown

Overview

This PR addresses issue #556 by automatically revoking campaign verification when the description is updated significantly. This ensures that verified content remains accurate and any major changes require re-verification by the community or admin.

Changes

  • Updated update_campaign_description in src/campaigns/update.rs to set campaign.is_verified = false if the campaign is currently verified.
  • Added decrement_verified_campaign_count in src/storage.rs to properly decrement the platform stats counter.
  • Updated test_campaign_update_description_success to verify verification revocation.

Verification

[npm run lint ✅ completed (existing repo warnings only)
npm run typecheck ✅ passed
npm test -- src/config/tests/config.test.ts --runInBand ✅ passed (9/9)
npm run build ✅ passed]

Fixes #556

@drips-wave

drips-wave Bot commented Jul 2, 2026

Copy link
Copy Markdown

@Banx17 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@davidmaronio davidmaronio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the description-update auto-revoke logic is correct (clears is_verified + decrement_verified_campaign_count with an underflow guard, and the test checks it), good. same scope issue as your #580 though, it's branched off the #581 milestone branch and carries ~20 files of that feature, please rebase onto clean main so it's just the description/verification change. fix the u32->u32 unnecessary cast (clippy) + cargo fmt. also this overlaps stellar #573 which does the same auto-revoke, you two should reconcile so only one lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] update_campaign_description fails to clear verified status on major edits

2 participants