Fix/global not found i18n - #739
Merged
Merged
Conversation
|
@TheShnider Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
davidmaronio
requested changes
Jul 4, 2026
davidmaronio
left a comment
davidmaronio
left a comment
Contributor
There was a problem hiding this comment.
the not-found.tsx page itself is fine, but this PR is much wider than its title and has one real regression that blocks it:
- it freezes all mock timestamps to MOCK_TIMESTAMP_SEC = 1700000000 (nov 2023) in contractClient.ts, campaignComments.ts, campaignUpdates.ts and devMockScenarios.ts. campaign deadlines become 1700000000 + N days, which is permanently in the past given today's date, so every mock campaign now renders as expired/ended. use a build-stable but still-future relative base instead of a hardcoded 2023 epoch.
- the e2e specs now swallow broad console errors ("JSHandle@object", "Uncaught error: Error"). that is likely why ci stayed green over the regression above. please drop the error suppression.
- the src/middleware.ts matcher broadening and the hydration/mounted gating are unrelated scope creep. split them out or justify them.
once the timestamps stay in the future and the error suppression is gone, happy to re-review.
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #625
Type of Change
Contributor Checklist
CONTRIBUTING.mdfor branch, commit, and PR title conventions.Validation
npm run lintnpm run format:checknpm run typechecknpm testnpm run buildNotes for Reviewers