Skip to content

Fixes - #721

Closed
blurbeast wants to merge 0 commit into
Iris-IV:mainfrom
blurbeast:main
Closed

Fixes#721
blurbeast wants to merge 0 commit into
Iris-IV:mainfrom
blurbeast:main

Conversation

@blurbeast

Copy link
Copy Markdown
Contributor

this pr resolves the issues tagged in this pr

closes #483
closes #484
closes #485
closes #486

@sshdopey

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@davidmaronio davidmaronio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's good stuff here (trending/related campaigns, csv export, leaderboard), two asks:

  1. please remove resolve.py from the repo root, it's a leftover merge-conflict-scanner script, not app code.
  2. the pr title "Fixes" is uninformative, can you rename it to describe the change (the commit headlines themselves are fine).
    it's also a large multi-feature pr, splitting would make it easier to review/merge but not required. the only failing check is our shared broken Playwright e2e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants