Skip to content

Add revenue claiming UI for EducationalStartup contributors#707

Merged
davidmaronio merged 2 commits into
Iris-IV:mainfrom
Frontman-Code:dashboard
Jul 13, 2026
Merged

Add revenue claiming UI for EducationalStartup contributors#707
davidmaronio merged 2 commits into
Iris-IV:mainfrom
Frontman-Code:dashboard

Conversation

@Frontman-Code

Copy link
Copy Markdown

Summary

Closes #597
Closes #596
Closes #600
Closes #570

Type of Change

  • Bug fix
  • Feature
  • Chore / maintenance
  • Documentation
  • Test coverage

Contributor Checklist

  • Linked the related issue above.
  • Reviewed CONTRIBUTING.md for branch, commit, and PR title conventions.
  • Confirmed this follows the current Stellar Wave contribution flow, if applicable.
  • Added or updated tests when behavior changed.
  • Updated docs, examples, or translations when needed.

Validation

  • npm run lint
  • npm run format:check
  • npm run typecheck
  • npm test
  • npm run build
  • Not run; reason:

Notes for Reviewers

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@Frontman-Code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@sshdopey

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@davidmaronio

Copy link
Copy Markdown
Contributor

git fetch origin && git rebase origin/main && git push --force-with-lease. once it's green i'll review and merge.

@davidmaronio davidmaronio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the revenue-claiming idea is welcome but this can't go in as-is, the file doesn't compile:

  1. src/app/[locale]/dashboard/DashboardClient.tsx has an unterminated string literal at line 173 plus unclosed jsx tags (div at 92, section at 164, ul at 169), so both tsc and the next build fail on it.
  2. lint has a real error too, the diff reverts You haven't back to You haven't which trips react/no-unescaped-entities, put the ' back.
    also the diff mostly deletes existing sections (MyContributionsSection, voting history) rather than adding revenue-claiming ui, so it doesn't match the title, can you reconcile that? fix the syntax so it builds and i'll re-review. the failing Playwright check is a known-broken e2e suite on our side, ignore that one.

@sshdopey

sshdopey commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

2 similar comments
@sshdopey

sshdopey commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@sshdopey

sshdopey commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@sshdopey

sshdopey commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

1 similar comment
@sshdopey

sshdopey commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@sshdopey

sshdopey commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@sshdopey sshdopey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has an empty or whitespace-only diff — no real code changes detected.

If you intended to push code, please commit it. Closing automatically; reopen once you have actual changes.

@sshdopey

sshdopey commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Closed: empty diff.

@davidmaronio davidmaronio merged commit b1bc736 into Iris-IV:main Jul 13, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants