Add revenue claiming UI for EducationalStartup contributors#707
Conversation
|
@Frontman-Code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Auto-review failed (API error). Leaving PR for human review. |
|
git fetch origin && git rebase origin/main && git push --force-with-lease. once it's green i'll review and merge. |
davidmaronio
left a comment
There was a problem hiding this comment.
the revenue-claiming idea is welcome but this can't go in as-is, the file doesn't compile:
- src/app/[locale]/dashboard/DashboardClient.tsx has an unterminated string literal at line 173 plus unclosed jsx tags (div at 92, section at 164, ul at 169), so both tsc and the next build fail on it.
- lint has a real error too, the diff reverts
You haven'tback toYou haven'twhich trips react/no-unescaped-entities, put the ' back.
also the diff mostly deletes existing sections (MyContributionsSection, voting history) rather than adding revenue-claiming ui, so it doesn't match the title, can you reconcile that? fix the syntax so it builds and i'll re-review. the failing Playwright check is a known-broken e2e suite on our side, ignore that one.
|
Auto-review failed (API error). Leaving PR for human review. |
2 similar comments
|
Auto-review failed (API error). Leaving PR for human review. |
|
Auto-review failed (API error). Leaving PR for human review. |
|
Auto-review failed (API error). Leaving PR for human review. |
1 similar comment
|
Auto-review failed (API error). Leaving PR for human review. |
|
Auto-review failed (API error). Leaving PR for human review. |
sshdopey
left a comment
There was a problem hiding this comment.
This PR has an empty or whitespace-only diff — no real code changes detected.
If you intended to push code, please commit it. Closing automatically; reopen once you have actual changes.
|
Closed: empty diff. |
Summary
Closes #597
Closes #596
Closes #600
Closes #570
Type of Change
Contributor Checklist
CONTRIBUTING.mdfor branch, commit, and PR title conventions.Validation
npm run lintnpm run format:checknpm run typechecknpm testnpm run buildNotes for Reviewers