More a reminder that a solution was found#5
Open
boiscljo wants to merge 46 commits intoIridium-Development:masterfrom
Open
More a reminder that a solution was found#5boiscljo wants to merge 46 commits intoIridium-Development:masterfrom
boiscljo wants to merge 46 commits intoIridium-Development:masterfrom
Conversation
* My attempt at adding hdl * Fixed hdl * Fixed hdl
* My attempt at adding hdl * Fixed hdl * Fixed hdl * Added undo option * Formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fix some blocks not correctly working like deepslate, the .getData().setData(byte) must be used instead of .setRawData(byte). (The rest of the code make sure it serializes as deepslate blocks didn't serialize before)
I suggest taking the code and doing the modification yourself to make sure everything is actually needed in. (Ignore the core version and the gradle file since the nexus is back up, It's not problematic to keep my 3rd party repo if you prefer)