Skip to content

Conversation

@gabezurita
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 22, 2025 17:14
@gabezurita gabezurita requested a review from a team as a code owner July 22, 2025 17:14
@gabezurita gabezurita requested a review from ishakun July 22, 2025 17:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a grammatical error in an auto-generated warning message by changing "DO NO EDIT" to "DO NOT EDIT" and makes minor formatting improvements to the README documentation.

  • Updates warning message text from "DO NO EDIT" to "DO NOT EDIT" in template generation and corresponding tests
  • Improves README formatting by adding syntax highlighting to code blocks and formatting the GitHub URL as a proper markdown link

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/kubernetes_template_rendering/template.rb Fixes grammatical error in auto-generated warning comment
spec/kubernetes_template_rendering/template_spec.rb Updates test expectations to match corrected warning message
README.md Adds bash syntax highlighting to code blocks and formats GitHub URL as markdown link

@gabezurita gabezurita enabled auto-merge July 22, 2025 17:16
Copy link
Contributor

@ishakun ishakun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gabezurita
Copy link
Contributor Author

gabezurita commented Jul 31, 2025

Hi @ishakun and @ttstarck , this did not merge due to the CI waiting on a green status that never returned:
image

I'll try to merge mainline to see if I get CI to run, but just FYI

This branch is already at the top of main. Re-running the entire ci suite to see if we can get this to work.

Bundle AuditExpected — Waiting for status to be reported is not returning.

@dcaddell dcaddell disabled auto-merge July 31, 2025 18:19
@dcaddell dcaddell merged commit 71155c2 into main Jul 31, 2025
4 checks passed
@dcaddell dcaddell deleted the non-production/fix-typo branch July 31, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants