Refactor: make budget metrics and compiled code size metrics usable independently of each other; #7172
+277
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unisay
added
No Changelog Required
Unisay
force-pushed
the
yura/compiled-code-size
branch
from
5c769f5 to
d5fe363
Compare
Unisay
commented
Jul 1, 2025
| @@ -1,6 +1,6 @@ | |||
| CPU: 218_533 | |||
| Memory: 1_032 | |||
| Term Size: 10 | |||
| Flat Size: 37 | |||
| Flat Size: 28 | |||
There was a problem hiding this comment.
I have verified: Flat-serialised representation of this program takes 28 bytes:
58 1a 01 01 00 32 93 57 46 00 38 01 60 00 4b d6 08 14 12 0d 08 85 43 21 d1 08 94 51
…ndependently of each other;
Unisay
force-pushed
the
yura/compiled-code-size
branch
from
d5fe363 to
9d9fcbd
Compare
SeungheonOh
reviewed
Jul 1, 2025
| uplc <- toUPlc compiledCode | ||
| let | ||
| termSize = UPLC.programSize uplc | ||
| flatSize = UPLC.serialisedSize $ UPLC.UnrestrictedProgram uplc |
There was a problem hiding this comment.
here type of uplc is UPLC.Program TPLC.Name uni fun () which will naturally have a different size of flat encoding
SeungheonOh
reviewed
Jul 1, 2025
| countFlatBytes :: CompiledCode ann -> Integer | ||
| countFlatBytes = | ||
| fromIntegral . BS.length . \case | ||
| SerializedCode plcBytes _pir _ -> plcBytes |
There was a problem hiding this comment.
plcBytes is flat encoding of UPLC.Program UPLC.NamedDeBruijn uni fun SrcSpans
SeungheonOh
reviewed
Jul 1, 2025
| import UntypedPlutusCore qualified as UPLC | ||
| import UntypedPlutusCore.Evaluation.Machine.Cek as Cek | ||
|
|
||
| type Term = UPLC.Term PLC.NamedDeBruijn DefaultUni DefaultFun () | ||
| type Program = UPLC.Program PLC.NamedDeBruijn DefaultUni DefaultFun () | ||
|
|
||
| -- | The size of a 'CompiledCodeIn' as measured in Flat bytes. | ||
| countFlatBytes :: CompiledCode ann -> Integer |
There was a problem hiding this comment.
I think this can go do PlutusTx.Code as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/IntersectMBO/plutus-private/issues/1657
sizePlc->countAstNodescountFlatBytes.Reworking the way the
CompiledCode's Flat size is measured led to smaller sizes in many golden files.I believe that current implementation is as close as possible to the
PlutusLedgerApi.Common.serialiseCompiledCode.