-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Pure definition in the metatheory #6964
base: master
Are you sure you want to change the base?
Conversation
Currently this definition of Purity also causes the certifier to say "no" to some of the tests. We should, obviously, fix that before we merge this. |
-- case applied to constr would reduce, and possibly be pure. | ||
case : {i : ℕ} {t : X ⊢}{vs ts : List (X ⊢)} | ||
→ lookup? i ts ≡ just t | ||
→ Pure t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's t
applied to vs
that needs to be Pure
.
Anyway, do feel free to just omit case
. Perhaps with a comment of what we discussed here.
sat-det sat-t sat-t₁ refl = trans (sym sat-t) sat-t₁ | ||
|
||
data Pure {X : Set} : (X ⊢) → Set where | ||
force : {t : X ⊢} → Pure t → Pure (force t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, delay b
is pure, force (delay b)
isn't necessarily pure. Except when b
is pure, which you also need to handle, because the implementation does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we agree that we only force delays (and builtins), so we don't need to handle force applied to arbitrary things?
|
||
unsat-builtin : {t₁ t₂ : X ⊢} {arity args : ℕ} | ||
→ saturation t₁ ≡ just (arity , args) | ||
→ arity > (suc args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't take wrong interleaving into account, I'll write it up separately.
But it complies with the current (wrong) implementation, so it's fine.
The previous Pure definition was just a stub. This works, although there are some differences from the Haskell and some open questions about some of the details.