Add ScriptContext test #6959
Add ScriptContext test #6959
Conversation
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This reverts commit 717d93f.
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
| {-# LANGUAGE OverloadedStrings #-} | ||
| {-# LANGUAGE TemplateHaskell #-} | ||
| {-# LANGUAGE TypeApplications #-} |
There was a problem hiding this comment.
I don't understand why Data-backed Marlowe is slightly faster now. The only relationship I can think of is that maybe it uses code from this module and adding these two extensions somehow made the compiler generate code which is slightly more optimal?
There was a problem hiding this comment.
After talking to @zliu41, and seeing that other tests have also been impacted, it's most likely from the two member' and insert' functions being exported, but it remains to be seen what exactly is going on with the Haskell Core. Anyway, we're lucky that the performance changes work in our favor.
ana-pantilie
temporarily deployed
to
github-pages
GitHub Actions
Inactive
| @@ -139,3 +192,34 @@ mkScriptContextEqualityOverheadCode sc = | |||
| in $$(PlutusTx.compile [|| scriptContextEqualityOverhead ||]) | |||
| `PlutusTx.unsafeApplyCode` PlutusTx.liftCodeDef sc | |||
| `PlutusTx.unsafeApplyCode` PlutusTx.liftCodeDef d | |||
|
|
|||
| forwardWithStakeTrick :: BuiltinData -> BuiltinData -> () | |||
There was a problem hiding this comment.
Add some comments - it's hard to tell from the name - forwardWithStakeTrick - what it does.
| error {Unit}) | ||
| {all dead. dead}) | ||
| {all dead. dead}) | ||
| (Constr 0 [Constr 0 [B #736f6d6543726564656e7469616c]]) |
There was a problem hiding this comment.
Don't include the script context in the golden files - it serves no purpose.
| || PlutusTx.equalsData obsScriptCred wdrlAtOne | ||
| then () | ||
| else | ||
| if Map.member' obsScriptCred rest |
There was a problem hiding this comment.
I don't think you need member' here - you can use PlutusTx.Data.List.elem (or something very similar).
Even if you do need to expose member', it should be exposed from the List module (since it has nothing to do with Map), and it should have Haddock.
Fixes https://github.com/IntersectMBO/plutus-private/issues/1479
The
AsDataversion is actually slightly better (in script size) than the manually optimised version! I am not entirely sure why, since I tried multiple versions of the manually optimised one, and this was the best one.