Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MsgGetMeasures to haddock description of NodeToClientV_20 #5080

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add MsgGetMeasures to haddock description of NodeToClientV_20 #5080

wants to merge 2 commits into from
+54 −17

Conversation

fraser-iohk
Copy link
Contributor

@fraser-iohk fraser-iohk commented Feb 13, 2025 •
edited
Loading

Description

This PR adds:

  • NodeToClientVersion handling to codecLocalTxMonitor, ensuring that we don't encode or decode MsgGetMeasures or MsgReplyGetMeasures unless NodeToClientVersion is at least NodeToClientV_20
  • an extra line of information to the haddock description of NodeToClientV_20 indicating that it's also going to be used for MsgReplyGetMeasures

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@fraser-iohk fraser-iohk requested a review from a team as a code owner February 13, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Ouroboros Network
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fraser-iohk