Expose hidden entities and small tweaks for integrating LSM-trees into the node #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
force-pushed
the
js/expose-for-node
branch
3 times, most recently
from
d29e657 to
7532ede
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
2 times, most recently
from
d691ba2 to
3fca3f5
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
7532ede to
91c24b9
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
3fca3f5 to
ac1b251
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
91c24b9 to
dd9a9c3
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
ac1b251 to
7b4251e
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
dd9a9c3 to
ba5f291
Compare
jasagredo
requested review from
amesgen,
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
7b4251e to
45d90f6
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
e268d97 to
84f25b6
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
45d90f6 to
25b3689
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
84f25b6 to
f4cd17c
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
25b3689 to
c578556
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
f4cd17c to
d253132
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
c578556 to
c6513dd
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
d253132 to
62c0375
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
c6513dd to
e56aeb5
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
62c0375 to
39904b5
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
e56aeb5 to
8a10d3f
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
39904b5 to
5f055b6
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
8a10d3f to
dc903ef
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
5f055b6 to
44a9da2
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
dc903ef to
63c4347
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
44a9da2 to
414f51d
Compare
dnadales
approved these changes
Oct 29, 2025
| srnSnapshotPolicyArgs :: SnapshotPolicyArgs | ||
| , srnQueryBatchSize :: QueryBatchSize | ||
| , srnLedgerDbBackendArgs :: LedgerDbBackendArgs m blk | ||
| , srnLedgerDbBackendArgs :: (StdGen -> (LedgerDbBackendArgs m blk, StdGen)) |
There was a problem hiding this comment.
Would it make sense to document why we have the extra parameter?
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
63c4347 to
2d514e4
Compare
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
2d514e4 to
cdfed5c
Compare
jasagredo
force-pushed
the
js/expose-for-node
branch
from
414f51d to
f12ecde
Compare
This was referenced Oct 31, 2025
jasagredo
force-pushed
the
js/fix-resource-registry
branch
from
cdfed5c to
b647dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose some constructors for the sake of integration into
cardano-node.