Add support for measures to LocalTxMonitor #1191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
nfrisby
force-pushed
the
nfrisby/consolidate-txlimits
branch
4 times, most recently
from
f15f603 to
a7bd1c5
Compare
fraser-iohk
force-pushed
the
fraser-iohk/localtxmonitor-measures
branch
from
16e7267 to
159d33f
Compare
nfrisby
force-pushed
the
nfrisby/consolidate-txlimits
branch
6 times, most recently
from
6ad371d to
9c022f3
Compare
fraser-iohk
force-pushed
the
fraser-iohk/localtxmonitor-measures
branch
4 times, most recently
from
2cc7f85 to
b1a95e9
Compare
add `fromByteSize :: Num a => ByteSize -> a`, with a WARNING that it will likely explode due to overflow
add TxMeasureMetrics
{Semigroup, Monoid} instances for {AlonzoMeasure, ConwayMeasure}
add TxMeasureMetrics class and instances
ByteSize -> TxMeasure blk in LocalTxMonitor.Server
respond with TxMeasureMetrics info inside a map of measures
stylish
merge changes from nick's branch
add patterns for MeasureName constructors that are no longer provided in network
fraser-iohk
force-pushed
the
fraser-iohk/localtxmonitor-measures
branch
from
df3eac7 to
06161c5
Compare
fraser-iohk
requested review from
nfrisby,
jasagredo,
amesgen,
dnadales and
geo2a
as code owners
jasagredo
reviewed
Feb 13, 2025
...ros-consensus-diffusion/changelog.d/20250213_115925_fraser.murray_localtxmonitor_measures.md
Outdated
Show resolved
Hide resolved
| @@ -24,3 +24,4 @@ nodeToClientVersionToQueryVersion x = case x of | |||
| NodeToClientV_17 -> QueryVersion2 | |||
| NodeToClientV_18 -> QueryVersion2 | |||
| NodeToClientV_19 -> QueryVersion2 | |||
| NodeToClientV_20 -> QueryVersion2 | |||
There was a problem hiding this comment.
I introduced a new query in #1373 that should make use of NodeToClientV_20 too. Just FYI.
fraser-iohk
force-pushed
the
fraser-iohk/localtxmonitor-measures
branch
from
06161c5 to
b05cacf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1178 and builds on #1175 by adding support for arbitrary measures to the
LocalTxMonitorserver inouroboros-consensus. Relevant changes toouroboros-networkare required to build these changes, since theLocalTxMonitorprotocol has been changed to add a newGetMeasuresmessage.Remaining work required before this can be merged:
ouroboros-networkPR needs to be mergeddeal withfromByteSizebeing very likely to silently overflow the new numeric type