fix(infra): remove the Cardano block producer configuration file - #3494
Merged
Conversation
The 'config-bp.json' file was a stale copy of 'config.json' that Cardano node '11.1.0' fails to parse. The block producer now uses 'config.json'.
* mithril-infra/assets/infra.version from `0.5.21` to `0.5.22`
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy config-bp.json Cardano node configuration handling for signer block producers, aligning the infrastructure with supported Cardano node versions (10.7+) and unblocking deployments on 11.1 by relying on the standard config.json.
Changes:
- Removed Terraform provisioning steps that created and maintained
config-bp.jsonfor signer Cardano block producers. - Updated the signer block-producer docker-compose override to start
cardano-nodewith/config/cardano-node/config.jsoninstead of/config/cardano-node/config-bp.json. - Bumped the infra version from
0.5.21to0.5.22.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mithril-infra/mithril.signer.tf | Drops the runtime creation/update of config-bp.json, leaving only config.json management per signer type. |
| mithril-infra/assets/infra.version | Version bump to reflect the infra change set. |
| mithril-infra/assets/docker/docker-compose-signer-cardano-bp-override.yaml | Switches block-producer cardano-node startup to use config.json directly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Results 5 files ± 0 209 suites ±0 1h 0m 57s ⏱️ - 1h 20m 36s Results for commit 4be388a. ± Comparison against base commit 6ca6181. This pull request removes 66 tests. |
jpraynaud
temporarily deployed
to
testing-preview
August 25, 2026 09:55 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-2-preview
August 25, 2026 09:55 — with
GitHub Actions
Inactive
Alenar
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the removal of the
config-bp.jsonconfiguration file used by the Cardano node block producer of the signers which is not needed for the supported Cardano versions (10.7+) and prevented the deployment with version11.1.Pre-submit checklist
Issue(s)
Relates to #3346