Skip to content

fix(infra): remove the Cardano block producer configuration file - #3494

Merged
jpraynaud merged 2 commits into
mainfrom
jpraynaud/3346-fix-infra-cardano-11.1
Aug 25, 2026
Merged

fix(infra): remove the Cardano block producer configuration file#3494
jpraynaud merged 2 commits into
mainfrom
jpraynaud/3346-fix-infra-cardano-11.1

Conversation

@jpraynaud

@jpraynaud jpraynaud commented Aug 25, 2026

Copy link
Copy Markdown
Member

Content

This PR includes the removal of the config-bp.json configuration file used by the Cardano node block producer of the signers which is not needed for the supported Cardano versions (10.7+) and prevented the deployment with version 11.1.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #3346

The 'config-bp.json' file was a stale copy of 'config.json' that Cardano
node '11.1.0' fails to parse. The block producer now uses 'config.json'.
* mithril-infra/assets/infra.version from `0.5.21` to `0.5.22`
@jpraynaud jpraynaud self-assigned this Aug 25, 2026
Copilot AI lite review requested due to automatic review settings August 25, 2026 09:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy config-bp.json Cardano node configuration handling for signer block producers, aligning the infrastructure with supported Cardano node versions (10.7+) and unblocking deployments on 11.1 by relying on the standard config.json.

Changes:

  • Removed Terraform provisioning steps that created and maintained config-bp.json for signer Cardano block producers.
  • Updated the signer block-producer docker-compose override to start cardano-node with /config/cardano-node/config.json instead of /config/cardano-node/config-bp.json.
  • Bumped the infra version from 0.5.21 to 0.5.22.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
mithril-infra/mithril.signer.tf Drops the runtime creation/update of config-bp.json, leaving only config.json management per signer type.
mithril-infra/assets/infra.version Version bump to reflect the infra change set.
mithril-infra/assets/docker/docker-compose-signer-cardano-bp-override.yaml Switches block-producer cardano-node startup to use config.json directly.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@turmelclem turmelclem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions

Copy link
Copy Markdown

Test Results

     5 files  ± 0     209 suites  ±0   1h 0m 57s ⏱️ - 1h 20m 36s
 3 396 tests  - 66   3 396 ✅  - 66  0 💤 ±0  0 ❌ ±0 
11 250 runs   - 75  11 250 ✅  - 75  0 💤 ±0  0 ❌ ±0 

Results for commit 4be388a. ± Comparison against base commit 6ca6181.

This pull request removes 66 tests.
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_out_of_bounds
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_too_large_for_circuit_range
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::indices_not_increasing
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_merkle_path_mismatch
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_swap_keep_merkle_path
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_wrong_verification_key
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_corrupt_sibling
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_flip_position
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_long
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_short
…

@jpraynaud
jpraynaud merged commit c243135 into main Aug 25, 2026
92 of 93 checks passed
@jpraynaud
jpraynaud deleted the jpraynaud/3346-fix-infra-cardano-11.1 branch August 25, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants