fix(infra): build wrapper Docker image with Cardano node 11.1.0 - #3493
Merged
Conversation
11.1.0
There was a problem hiding this comment.
Pull request overview
This PR fixes the build of the Cardano wrapper Docker image when targeting Cardano node 11.1.0, accommodating the change where /usr/local/bin/env is now a symlink created at runtime by the entrypoint.
Changes:
- Make the env-file permissions adjustment conditional, only applying it when
/usr/local/bin/envis not a symlink. - Add inline documentation explaining the
11.1.0symlink behavior to justify the conditional logic.
Suppressed comments (2)
mithril-infra/assets/docker/Dockerfile.cardano:10
- The phrasing "needs no rights fix" is unclear/incorrect in English; consider rewording to indicate that no permission changes are required.
# created by the entrypoint under '/tmp' and needs no rights fix
mithril-infra/assets/docker/Dockerfile.cardano:16
- Spelling: "migt" should be "might" in this comment.
# you migt have to run manually this command as 'root' user to update ownership of some folders
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
turmelclem
approved these changes
Aug 24, 2026
jpraynaud
temporarily deployed
to
testing-preview
August 24, 2026 15:22 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-2-preview
August 24, 2026 15:22 — with
GitHub Actions
Inactive
Alenar
approved these changes
Aug 24, 2026
jpraynaud
force-pushed
the
jpraynaud/3346-fix-cardano-docker-wrapper
branch
from
August 24, 2026 15:30
308770d to
51b08b3
Compare
jpraynaud
temporarily deployed
to
testing-preview
August 24, 2026 15:45 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-2-preview
August 24, 2026 15:45 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix of the wrapper Docker image build of the Cardano node with version
11.1.0Pre-submit checklist
Issue(s)
Relates to #3346