Skip to content

fix(infra): build wrapper Docker image with Cardano node 11.1.0 - #3493

Merged
jpraynaud merged 1 commit into
mainfrom
jpraynaud/3346-fix-cardano-docker-wrapper
Aug 24, 2026
Merged

fix(infra): build wrapper Docker image with Cardano node 11.1.0#3493
jpraynaud merged 1 commit into
mainfrom
jpraynaud/3346-fix-cardano-docker-wrapper

Conversation

@jpraynaud

@jpraynaud jpraynaud commented Aug 24, 2026

Copy link
Copy Markdown
Member

Content

This PR includes a fix of the wrapper Docker image build of the Cardano node with version 11.1.0

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #3346

@jpraynaud jpraynaud self-assigned this Aug 24, 2026
Copilot AI lite review requested due to automatic review settings August 24, 2026 15:03
@jpraynaud jpraynaud changed the title fix(infra): wrapper Docker image for Cardano node fix(infra): build wrapper Docker image with Cardano node 11.1.0 Aug 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the build of the Cardano wrapper Docker image when targeting Cardano node 11.1.0, accommodating the change where /usr/local/bin/env is now a symlink created at runtime by the entrypoint.

Changes:

  • Make the env-file permissions adjustment conditional, only applying it when /usr/local/bin/env is not a symlink.
  • Add inline documentation explaining the 11.1.0 symlink behavior to justify the conditional logic.
Suppressed comments (2)

mithril-infra/assets/docker/Dockerfile.cardano:10

  • The phrasing "needs no rights fix" is unclear/incorrect in English; consider rewording to indicate that no permission changes are required.
# created by the entrypoint under '/tmp' and needs no rights fix

mithril-infra/assets/docker/Dockerfile.cardano:16

  • Spelling: "migt" should be "might" in this comment.
# you migt have to run manually this command as 'root' user to update ownership of some folders

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread mithril-infra/assets/docker/Dockerfile.cardano Outdated
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

Test Results

     5 files  ±0     209 suites  ±0   51m 2s ⏱️ - 6m 17s
 3 396 tests ±0   3 396 ✅ ±0  0 💤 ±0  0 ❌ ±0 
11 250 runs  ±0  11 250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 51b08b3. ± Comparison against base commit c548fff.

♻️ This comment has been updated with latest results.

@jpraynaud
jpraynaud force-pushed the jpraynaud/3346-fix-cardano-docker-wrapper branch from 308770d to 51b08b3 Compare August 24, 2026 15:30
@jpraynaud
jpraynaud temporarily deployed to testing-2-preview August 24, 2026 15:45 — with GitHub Actions Inactive
@jpraynaud
jpraynaud merged commit bb85879 into main Aug 24, 2026
50 checks passed
@jpraynaud
jpraynaud deleted the jpraynaud/3346-fix-cardano-docker-wrapper branch August 24, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants