Skip to content

Adapt end-to-end test for on-chain configuration parameters - #3489

Merged
turmelclem merged 3 commits into
mainfrom
ctl/3396-adapt-end-to-end-tests-for-on-chain-configuration-parameters-2
Aug 25, 2026
Merged

Adapt end-to-end test for on-chain configuration parameters#3489
turmelclem merged 3 commits into
mainfrom
ctl/3396-adapt-end-to-end-tests-for-on-chain-configuration-parameters-2

Conversation

@turmelclem

@turmelclem turmelclem commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Content

Adapting e2e test to support on chain configuration :

  • add scripts to create payment address, send funds to address, write datums
  • add new PROTOCOL_CONFIGURATION_READER_ADAPTER_CONFIG in both signer and aggregator configuration
  • regarding aggregator version, write protocol configurations and signing config on chain or in environment variables
  • regarding signer version and e2e test argument, read protocol configurations on-chain or through Aggregator HTTP routes

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Closes #3396

@github-actions

github-actions Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

     5 files  ±0     209 suites  ±0   1h 4m 17s ⏱️ + 7m 41s
 3 396 tests ±0   3 396 ✅ ±0  0 💤 ±0  0 ❌ ±0 
11 250 runs  ±0  11 250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ad65ef2. ± Comparison against base commit c243135.

♻️ This comment has been updated with latest results.

@turmelclem
turmelclem temporarily deployed to testing-2-preview August 24, 2026 12:12 — with GitHub Actions Inactive
@jpraynaud
jpraynaud requested a lite review from Copilot August 24, 2026 12:25
Copilot AI reviewed Aug 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adapts the mithril end-to-end test lab to exercise the new on-chain protocol configuration path (writing protocol parameters/signing config markers on the devnet chain and configuring signer/aggregator to read them), while keeping a fallback path for older aggregator versions.

Changes:

  • Add support for protocol-configuration markers (address discovery, datum generation, chain write) and wire PROTOCOL_CONFIGURATION_READER_ADAPTER_CONFIG into signer and aggregator processes.
  • Introduce a ProtocolConfiguration model in the e2e infrastructure and use it to register startup protocol configuration and perform on-chain protocol-parameter updates when supported.
  • Add devnet mkfiles script generation for protocol-configuration and a devnet runner method to write protocol-configuration markers on-chain.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
mithril-test-lab/mithril-end-to-end/src/toolkit/exec.rs Adds marker registration helper and switches protocol-parameter updates to on-chain registration when supported.
mithril-test-lab/mithril-end-to-end/src/stress_test/aggregator_helpers.rs Extends aggregator bootstrap config and sets signing config for stress tests.
mithril-test-lab/mithril-end-to-end/src/scenario/full.rs Updates scenario call-site to pass infrastructure + epoch for protocol-parameter updates.
mithril-test-lab/mithril-end-to-end/src/mithril/signer.rs Adds protocol configuration reader adapter env var wiring for signer.
mithril-test-lab/mithril-end-to-end/src/mithril/mod.rs Re-exports ProtocolConfiguration and adds protocol-configuration marker key constants.
mithril-test-lab/mithril-end-to-end/src/mithril/infrastructure.rs Introduces ProtocolConfiguration, stores startup configuration, and registers startup markers when on-chain mode is enabled.
mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs Adds protocol configuration reader adapter env var wiring, on-chain mode detection, datum generation command, and signing-config setter.
mithril-test-lab/mithril-end-to-end/src/main.rs Adds CLI arg + startup protocol configuration construction and passes it into infrastructure config.
mithril-test-lab/mithril-end-to-end/src/devnet/runner.rs Adds protocol-configuration marker address support and a method to write protocol-configuration markers on-chain.
mithril-test-lab/cardano-devnet/mkfiles/mkfiles-protocol-configuration.sh Adds mkfiles script to generate protocol-config address and a script to fund it and write inline datum on-chain.
mithril-test-lab/cardano-devnet/devnet-mkfiles.sh Sources the new mkfiles protocol-configuration generator.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs
Comment thread mithril-test-lab/cardano-devnet/mkfiles/mkfiles-protocol-configuration.sh Outdated
Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs Outdated
Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/infrastructure.rs Outdated
@turmelclem
turmelclem force-pushed the ctl/3396-adapt-end-to-end-tests-for-on-chain-configuration-parameters-2 branch from 49c548f to 1cdfe9b Compare August 24, 2026 13:10
@turmelclem
turmelclem temporarily deployed to testing-2-preview August 24, 2026 13:33 — with GitHub Actions Inactive
Alenar
Alenar approved these changes Aug 24, 2026
View reviewed changes

@Alenar Alenar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread mithril-test-lab/cardano-devnet/mkfiles/mkfiles-protocol-configuration.sh
Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs
Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs Outdated
Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs
@turmelclem
turmelclem force-pushed the ctl/3396-adapt-end-to-end-tests-for-on-chain-configuration-parameters-2 branch from 1cdfe9b to a4e786d Compare August 24, 2026 19:54
@turmelclem
turmelclem deployed to testing-2-preview August 24, 2026 20:11 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-preview August 24, 2026 20:11 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-2-preview August 25, 2026 08:37 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-preview August 25, 2026 08:37 — with GitHub Actions Active
jpraynaud
jpraynaud reviewed Aug 25, 2026
View reviewed changes

@jpraynaud jpraynaud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs
Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs Outdated
Comment thread mithril-test-lab/mithril-end-to-end/src/mithril/aggregator.rs
Comment thread mithril-test-lab/mithril-end-to-end/src/scenario/full.rs
@turmelclem
turmelclem force-pushed the ctl/3396-adapt-end-to-end-tests-for-on-chain-configuration-parameters-2 branch from ef830f7 to d6c2ce8 Compare August 25, 2026 14:06
@turmelclem
turmelclem force-pushed the ctl/3396-adapt-end-to-end-tests-for-on-chain-configuration-parameters-2 branch from d6c2ce8 to 85e46ae Compare August 25, 2026 14:08
@turmelclem
refactor(end-to-end): add a argument for signers to read protocol con…
81ecb86 
…figuration on-chain (or through aggregator HTTP routes by default)
@turmelclem
chore: upgrade crate versions and `mithril-test-lab/cardano-devnet/VE…
ad65ef2 
…RSION` version

* mithril-end-to-end from `0.5.13` to `0.5.14`
* mithril-test-lab/cardano-devnet/VERSION from `0.4.39` to `0.4.40`
@turmelclem
turmelclem force-pushed the ctl/3396-adapt-end-to-end-tests-for-on-chain-configuration-parameters-2 branch from 85e46ae to ad65ef2 Compare August 25, 2026 14:14
@turmelclem
turmelclem deployed to testing-2-preview August 25, 2026 14:32 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-preview August 25, 2026 14:32 — with GitHub Actions Active
jpraynaud
jpraynaud approved these changes Aug 25, 2026
View reviewed changes

@jpraynaud jpraynaud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@turmelclem
turmelclem merged commit 6c07092 into main Aug 25, 2026
50 checks passed
@turmelclem
turmelclem deleted the ctl/3396-adapt-end-to-end-tests-for-on-chain-configuration-parameters-2 branch August 25, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@Alenar Alenar Alenar approved these changes
@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@turmelclem turmelclem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapt end-to-end test for on-chain configuration parameters

4 participants

@turmelclem @Alenar @jpraynaud