Skip to content

Implement chain adapater to read on chain protocol configurations - #3482

Open
turmelclem wants to merge 7 commits into
mainfrom
ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2
Open

Implement chain adapater to read on chain protocol configurations#3482
turmelclem wants to merge 7 commits into
mainfrom
ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2

Conversation

@turmelclem

@turmelclem turmelclem commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Content

This PR includes modification to implement chain adapater to read on chain protocol configurations :

  • Implement on-chain reader for protocol configurations
  • move mechanism checking configuration consistency in model
  • add markers implementation of MithrilNetworkConfigurationProvider
  • Implement a protocol configuration builder (used by Signer and Aggregator)
  • Wire MarkersMithrilNetworkConfigurationProvider in the Signer
  • Wire MarkersMithrilNetworkConfigurationProvider instead of local impl for leader aggregator
    • tests have been adapted to read protocol configurations from makers instead of aggregator configuration
  • Refactor usage of parameters for protocol-configuration commands

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Relates to #3393

@turmelclem
turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from 4f87a71 to cb72f72 Compare August 17, 2026 09:56
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

Test Results

     5 files     209 suites   58m 46s ⏱️
 3 381 tests  3 381 ✅ 0 💤 0 ❌
11 256 runs  11 256 ✅ 0 💤 0 ❌

Results for commit 551848d.

♻️ This comment has been updated with latest results.

@turmelclem
turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from cb72f72 to 9a7ac9a Compare August 17, 2026 16:10
Comment thread internal/mithril-protocol-config/src/builder.rs Fixed
Comment thread internal/mithril-protocol-config/src/builder.rs Fixed
Comment thread internal/mithril-protocol-config/src/builder.rs Fixed
Comment thread internal/mithril-protocol-config/src/builder.rs Fixed
Comment thread internal/mithril-protocol-config/src/builder.rs Fixed
Comment thread internal/mithril-protocol-config/src/builder.rs Fixed
@turmelclem turmelclem self-assigned this Aug 18, 2026
@turmelclem
turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from 9a7ac9a to 4a79c83 Compare August 18, 2026 16:36
Comment thread mithril-aggregator/tests/genesis_to_signing.rs Fixed
@turmelclem
turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from 4a79c83 to 192a144 Compare August 19, 2026 09:59
Comment thread mithril-signer/src/configuration.rs Fixed
@turmelclem
turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from 192a144 to 38c6548 Compare August 19, 2026 12:25
@turmelclem
turmelclem marked this pull request as ready for review August 19, 2026 13:06
@turmelclem
turmelclem force-pushed the ctl/3393-implement-chain-adapater-to-read-on-chain-protocol-configurations-2 branch from 38c6548 to 551848d Compare August 19, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants