Skip to content

feat(stm): Prepare Prover Witness - #3074

Closed
curiecrypt wants to merge 11 commits into
mainfrom
curiecrypt/2887-prepare-prover-witness
Closed

feat(stm): Prepare Prover Witness#3074
curiecrypt wants to merge 11 commits into
mainfrom
curiecrypt/2887-prepare-prover-witness

Conversation

@curiecrypt

Copy link
Copy Markdown
Collaborator

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@curiecrypt curiecrypt self-assigned this Mar 6, 2026
Comment thread mithril-stm/src/proof_system/halo2_snark/clerk.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/clerk.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/instance.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/instance.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/instance.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/signer_witness.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/signer_witness.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/witness_entry.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/clerk.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/clerk.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/instance.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/instance.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/instance.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/signer_witness.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/signer_witness.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/witness_entry.rs Fixed
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown

Test Results

    5 files  ±0    190 suites  ±0   59m 55s ⏱️ + 4m 32s
2 651 tests +1  2 642 ✅  -  8  0 💤 ±0  9 ❌ +9 
9 499 runs   - 3  9 490 ✅  - 12  0 💤 ±0  9 ❌ +9 

For more details on these failures, see this check.

Results for commit 6885696. ± Comparison against base commit 4e6efa8.

This pull request removes 4 and adds 5 tests. Note that renamed tests count towards both.
mithril-stm ‑ protocol::single_signature::signature::tests::verify_fails_with_different_registration_avk
mithril-stm ‑ protocol::single_signature::signature::tests::verify_fails_with_out_of_bounds_index
mithril-stm ‑ protocol::single_signature::signature::tests::verify_fails_with_wrong_message
mithril-stm ‑ protocol::single_signature::signature::tests::verify_fails_with_wrong_verification_key
mithril-stm ‑ proof_system::halo2_snark::witness::proof::tests::deduplicate_indices
mithril-stm ‑ protocol::single_signature::signature::tests::verify_concatenation_only::verify_fails_with_different_registration_avk
mithril-stm ‑ protocol::single_signature::signature::tests::verify_concatenation_only::verify_fails_with_out_of_bounds_index
mithril-stm ‑ protocol::single_signature::signature::tests::verify_concatenation_only::verify_fails_with_wrong_message
mithril-stm ‑ protocol::single_signature::signature::tests::verify_concatenation_only::verify_fails_with_wrong_verification_key

♻️ This comment has been updated with latest results.

Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/single_signature.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/single_signature.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
Comment thread mithril-stm/src/proof_system/halo2_snark/witness/proof.rs Fixed
@curiecrypt
curiecrypt force-pushed the curiecrypt/2887-prepare-prover-witness branch from ef735b9 to 0568ea6 Compare March 6, 2026 23:39
@curiecrypt curiecrypt closed this Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants