Follow-up from review on PR #554 #572
Merged
+44
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typos and stale / inaccurate comments.
by making it a newtype for UnspentCredits rather than Credits, so when unwrapping one layer its still compatible with other credit values and we can perform operations.
We do now check that we do not do too much merging work. But we could still supply excess credits leading to unexpected leftover credits. Add TODOs in the right places about asserting there are no leftover credits. We can't assert this yet because there are in fact leftovers because we do not spread out merging work fully, in the case that runs are less than worst case in size.
These are not concurrency safe. The merging runs could complete during snapshot persistence leading to use after free. Add TODOs to explain this and to suggest a solution.
And remove a stale comment about non-zero cases and replace it by an assertion.
dcoutts
requested review from
jorisdral,
mheinzel,
recursion-ninja and
wenkokke
as code owners
mheinzel
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional post-merge PR review.