Semigroup and semantic tests for union and regular Entrys
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
commented
Jan 23, 2025
jorisdral
force-pushed
the
jdral/union-entry-semigroup
branch
3 times, most recently
from
605e963 to
5f1411e
Compare
mheinzel
reviewed
Jan 24, 2025
jorisdral
force-pushed
the
jdral/union-entry-semigroup
branch
4 times, most recently
from
4962d8d to
2ea1734
Compare
jorisdral
force-pushed
the
jdral/union-entry-semigroup
branch
from
2ea1734 to
2697942
Compare
jorisdral
changed the title
Entry forms a Semigroup with combineUnionSemigroup and semantic tests for union and regular Entrys
jorisdral
force-pushed
the
jdral/normal-union
branch
from
2ffba18 to
a01b035
Compare
It was shrinking both fields of the `BlobSpan` at the same time, though it's arguably better to shrink only the one or the other in a single shrinker step.
It is similar to `prop_MergeDistributes`, and we'll test the semantics of `combineUnion` separately.
We also update `combineUnion` to convert `Mupdate`s into `Insert`s unconditionally. This was already specified by the haddocks on `combineUnion`, but we were not doing this in cases where the left or right entry was a `Delete`.
jorisdral
force-pushed
the
jdral/union-entry-semigroup
branch
from
2697942 to
afb675d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #536, suggesting some changes that came up while reading the PR