Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: constitution type proposal #2970

Merged
merged 10 commits into from
Feb 13, 2025
Merged

Tests: constitution type proposal #2970

merged 10 commits into from
Feb 13, 2025

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Feb 13, 2025 •
edited
Loading

List of changes

  • Fix previous proposal test due to updates on proposal type test ids
  • Rename skipIfTreasuryAndBootstrapping to skipIfNotInfoAndBootstrapping and reject all proposal type than info on bootstrap
  • Support validation, visibility and submission tests to update the constitutional type proposal

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip February 13, 2025 12:01
@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

mesudip
mesudip approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mesudip mesudip merged commit 16be6c9 into develop Feb 13, 2025
4 of 6 checks passed
@mesudip mesudip deleted the tests/constitution-type-proposal branch February 13, 2025 12:11
@github-actions GitHub Actions
Copy link
Contributor

@kneerose
This PR is in the tag: develop-16be6c9835e05e8e654ece028e78ce43e179e89b , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link
Contributor

@kneerose
This PR is in the tag: develop-16be6c9835e05e8e654ece028e78ce43e179e89b , for govtool-frontend service

@github-actions GitHub Actions
Copy link
Contributor

@kneerose
This PR is in the tag: develop-16be6c9835e05e8e654ece028e78ce43e179e89b , for govtool-backend service

@kneerose kneerose mentioned this pull request Feb 14, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip