Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1188): add button to submit a governance action #2949

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ changes.
- Add metadata url and hash to drep details [Issue 2911](https://github.com/IntersectMBO/govtool/issues/2911)
- Add CC votes percentages, not voted and Ratification threshold
- Add support for submitting all 7 governance action types [Issue 2258](https://github.com/IntersectMBO/govtool/issues/2258)
- Add Propose Governance Action button in governance actions dashboard [Issue 1188](https://github.com/IntersectMBO/govtool/issues/1188)

### Fixed

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { useState, useEffect } from "react";
import { useState, useEffect, useCallback } from "react";
import { Box, CircularProgress, Tab, Tabs, styled } from "@mui/material";
import { useLocation } from "react-router-dom";
import { useLocation, useNavigate } from "react-router-dom";

import {
GOVERNANCE_ACTIONS_FILTERS,
GOVERNANCE_ACTIONS_SORTING,
PATHS,
PDF_PATHS,
} from "@consts";
import { useCardano, useDataActionsBar } from "@context";
import { useCardano, useDataActionsBar, useFeatureFlag } from "@context";
import {
useGetProposalsQuery,
useGetVoterInfo,
Expand All @@ -18,6 +20,7 @@ import {
GovernanceActionsToVote,
DashboardGovernanceActionsVotedOn,
} from "@organisms";
import { Button } from "@atoms";

type TabPanelProps = {
children?: React.ReactNode;
Expand Down Expand Up @@ -74,6 +77,8 @@ export const DashboardGovernanceActions = () => {
const { isMobile } = useScreenDimension();
const { t } = useTranslation();
const { isEnableLoading } = useCardano();
const { isProposalDiscussionForumEnabled } = useFeatureFlag();
const navigate = useNavigate();

const queryFilters =
chosenFilters.length > 0 ? chosenFilters : defaultCategories;
Expand All @@ -94,6 +99,14 @@ export const DashboardGovernanceActions = () => {
setContent(newValue);
};

const onClickPropose = useCallback(() => {
navigate(
isProposalDiscussionForumEnabled
? PDF_PATHS.proposalDiscussionPropose
: PATHS.createGovernanceAction,
);
}, [isProposalDiscussionForumEnabled]);

useEffect(() => {
window.history.replaceState({}, document.title);
}, []);
Expand Down Expand Up @@ -126,36 +139,49 @@ export const DashboardGovernanceActions = () => {
) : (
<>
{(voter?.isRegisteredAsDRep || voter?.isRegisteredAsSoleVoter) && (
<Tabs
sx={{
marginTop: 3,
display: "flex",
fontSize: 16,
fontWeight: 500,
}}
value={content}
indicatorColor="secondary"
onChange={handleChange}
aria-label="Governance Actions tabs"
>
<StyledTab
data-testid="to-vote-tab"
label={t("govActions.toVote")}
<Box display="flex" flexDirection="row" alignItems="center">
<Tabs
sx={{
textTransform: "none",
width: !isMobile ? "auto" : "50%",
marginTop: 3,
display: "flex",
fontSize: 16,
fontWeight: 500,
}}
/>
<StyledTab
data-testid="voted-tab"
label={t("govActions.votedOnByMe")}
value={content}
indicatorColor="secondary"
onChange={handleChange}
aria-label="Governance Actions tabs"
>
<StyledTab
data-testid="to-vote-tab"
label={t("govActions.toVote")}
sx={{
textTransform: "none",
width: !isMobile ? "auto" : "50%",
}}
/>
<StyledTab
data-testid="voted-tab"
label={t("govActions.votedOnByMe")}
sx={{
textTransform: "none",
width: !isMobile ? "auto" : "50%",
}}
/>
</Tabs>
<Button
data-testid="proposal-discussion-link"
onClick={onClickPropose}
sx={{
textTransform: "none",
width: !isMobile ? "auto" : "50%",
display: isMobile ? "none" : "block",
ml: "auto",
}}
/>
</Tabs>
>
{t("govActions.propose")}
</Button>
</Box>
)}

<Box height={isMobile ? 24 : 60} />
<CustomTabPanel value={content} index={0}>
<GovernanceActionsToVote
Expand Down
1 change: 1 addition & 0 deletions govtool/frontend/src/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@
"noResultsForTheSearch": "No results for the search.",
"onChainTransactionDetails": "On-chain Transaction Details",
"optional": "(optional)",
"propose": "Propose Governance Action",
"provideContext": "Provide context",
"provideContextAboutYourVote": "Provide context about your vote",
"additionalInformationAboutYourVote": "Additional information about your vote",
Expand Down
3 changes: 1 addition & 2 deletions govtool/frontend/src/pages/GovernanceActions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import { useNavigate } from "react-router-dom";
import { Box, CircularProgress, Divider } from "@mui/material";

import { Background, ScrollToManage, Typography } from "@atoms";
import { Background, Button, ScrollToManage, Typography } from "@atoms";

Check failure on line 5 in govtool/frontend/src/pages/GovernanceActions.tsx

View workflow job for this annotation

GitHub Actions / lint

'Button' is defined but never used
import {
GOVERNANCE_ACTIONS_FILTERS,
GOVERNANCE_ACTIONS_SORTING,
Expand Down Expand Up @@ -96,7 +96,6 @@
filtersTitle={t("govActions.filterTitle")}
sortOptions={GOVERNANCE_ACTIONS_SORTING}
/>

{!proposals || isProposalsLoading ? (
<Box
sx={{
Expand Down
Loading