fix(scripts): handle genesis extraConfig from cardano-cli 11.2 - #153
Merged
Conversation
cardano-cli >= PR #1384 writes initial funds and staking into the new "extraConfig" field (ledger's streaming data injection) and leaves the legacy "initialFunds"/"staking" fields empty. Nodes built with cardano-ledger-shelley < 1.19 silently ignore "extraConfig", so the cluster would start with an empty UTxO set. Detect "extraConfig" support in the node binary and move the data back to the legacy fields when the node cannot parse it. The slow (Byron funds) setup drops "extraConfig" unconditionally, as it never wants Shelley initial funds.
There was a problem hiding this comment.
Pull request overview
Adds a compatibility shim to keep common-start-fast/common-start-slow working with newer cardano-cli output where Shelley genesis initial funds / staking may be emitted under extraConfig, while older nodes may silently ignore it.
Changes:
common-start-fast: detect whether thecardano-nodebinary supports Shelley genesisextraConfiginjection and, if not, downgrade embedded injection data back into legacyinitialFunds/stakingfields.common-start-slow: explicitly dropextraConfigfrom Shelley genesis (in addition to clearinginitialFunds) since slow setup funds come from Byron.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/cardonnay_scripts/scripts/common/common-start-slow | Clears initialFunds and deletes .extraConfig in the generated Shelley genesis for the slow setup. |
| src/cardonnay_scripts/scripts/common/common-start-fast | Adds node feature detection and a jq-based downgrade path from .extraConfig to legacy Shelley genesis fields for older ledgers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cardano-cli >= PR #1384 writes initial funds and staking into the new "extraConfig" field (ledger's streaming data injection) and leaves the legacy "initialFunds"/"staking" fields empty. Nodes built with cardano-ledger-shelley < 1.19 silently ignore "extraConfig", so the cluster would start with an empty UTxO set.
Detect "extraConfig" support in the node binary and move the data back to the legacy fields when the node cannot parse it. The slow (Byron funds) setup drops "extraConfig" unconditionally, as it never wants Shelley initial funds.