cardano-testnet | Add test submitting transaction with reference inputs and actual datums #6174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
from
72e96a7 to
e6c49a9
Compare
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
4 times, most recently
from
e633ef2 to
f657b53
Compare
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
4 times, most recently
from
9d19c0a to
17f89d5
Compare
3 tasks
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
2 times, most recently
from
790ae17 to
9643429
Compare
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
2 times, most recently
from
fa1c711 to
2b5aed5
Compare
carbolymer
changed the title
Jimbo4350
reviewed
May 15, 2025
cardano-testnet/src/Testnet/Types.hs
Outdated
| @@ -148,6 +150,18 @@ isTestnetNodeSpo = isJust . poolKeys | |||
| nodeSocketPath :: TestnetNode -> SocketPath | |||
| nodeSocketPath = File . H.sprocketSystemName . nodeSprocket | |||
|
|
|||
| -- | Connection data for the first node in the testnet | |||
| node0ConnectionInfo :: MonadTest m => TestnetRuntime -> m LocalNodeConnectInfo | |||
There was a problem hiding this comment.
What about exposing an index parameter?
There was a problem hiding this comment.
I figured that for >0 indices, the connection info won't be that useful - those are relay nodes. I can add an index.
| import qualified Hedgehog.Extras.Test.TestWatchdog as H | ||
|
|
||
|
|
||
| -- | Test providing actual datum to reference inputs containing datum hashes |
There was a problem hiding this comment.
I don't understand what this means. Can you elaborate on what this test is testing and how this differs from "normal" datum usage.
There was a problem hiding this comment.
Added more comments.
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
2 times, most recently
from
7793a60 to
e410166
Compare
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
from
e410166 to
5963444
Compare
carbolymer
commented
May 19, 2025
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
2 times, most recently
from
4f9f87c to
fa3d95a
Compare
carbolymer
force-pushed
the
mgalazyn/test/submit-tx-api-datum
branch
from
fa3d95a to
1bd9228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests IntersectMBO/cardano-api#803
Stacked on top of:
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.