Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: small fixes for tracing in node and workbench #6104

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Icelandjack
Copy link
Contributor

@Icelandjack Icelandjack commented Feb 5, 2025

Description

  • Fixes the way the port is displayed in the node information (without an accidental layer of Maybe).
  • Fixes tracing with new Consensus tracers GDD, GSM and CSJ for the new tracing system.
  • workbench: adjust for renamed UTxO-HD tracers; enablesGSM trace messages

Checklist

  • [y] Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@Icelandjack Icelandjack requested a review from a team as a code owner February 5, 2025 15:11
@mgmeier mgmeier requested review from a team as code owners February 5, 2025 16:16
@mgmeier mgmeier closed this Feb 5, 2025
@mgmeier mgmeier reopened this Feb 5, 2025
@mgmeier mgmeier changed the title Fix port display bench-master: small fixes for node and workbench Feb 5, 2025
@mgmeier mgmeier changed the title bench-master: small fixes for node and workbench bench: small fixes for tracing in node and workbench Feb 5, 2025
@mgmeier mgmeier marked this pull request as draft February 5, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants