Skip to content

constrained-generators: Simplify HasSpec instance for Bool and move more things to NumSpec #5061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

MaximilianAlgehed
Copy link
Collaborator

Description

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@MaximilianAlgehed MaximilianAlgehed requested a review from a team as a code owner May 21, 2025 06:59
@MaximilianAlgehed MaximilianAlgehed force-pushed the max/simplify-bool-instance branch 2 times, most recently from dea598e to 0c77765 Compare May 21, 2025 12:05
@MaximilianAlgehed MaximilianAlgehed force-pushed the max/simplify-bool-instance branch from 0c77765 to d2fbb42 Compare May 26, 2025 08:04
@MaximilianAlgehed MaximilianAlgehed changed the title constrained-generators: Simplify HasSpec instance for Bool constrained-generators: Simplify HasSpec instance for Bool and move more things to NumSpec May 26, 2025
@MaximilianAlgehed MaximilianAlgehed force-pushed the max/simplify-bool-instance branch 7 times, most recently from eb330f0 to 983208f Compare May 26, 2025 13:01
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really does simplify things. Just add a few comments as suggested

@MaximilianAlgehed MaximilianAlgehed force-pushed the max/simplify-bool-instance branch from 9a7b05d to 23cbf40 Compare May 28, 2025 09:29
@MaximilianAlgehed MaximilianAlgehed enabled auto-merge (rebase) May 28, 2025 09:29
@MaximilianAlgehed MaximilianAlgehed merged commit 442d75e into master May 28, 2025
126 of 128 checks passed
@MaximilianAlgehed MaximilianAlgehed deleted the max/simplify-bool-instance branch May 28, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants