Remove MemoBytes from ShelleyTx
#5038
Merged
+311
−539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
changed the title
MemoBytes from ShelleyTxBodyMemoBytes from ShelleyTx
Soupstraw
force-pushed
the
jj/remove-shelley-tx-memo
branch
6 times, most recently
from
4a9594f to
e42d30b
Compare
Soupstraw
force-pushed
the
jj/remove-shelley-tx-memo
branch
2 times, most recently
from
f4c0163 to
58f3d23
Compare
lehins
requested changes
May 22, 2025
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Binary/Annotator.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Binary/Annotator.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/remove-shelley-tx-memo
branch
8 times, most recently
from
2e86da7 to
6db32ad
Compare
lehins
reviewed
May 23, 2025
Soupstraw
force-pushed
the
jj/remove-shelley-tx-memo
branch
8 times, most recently
from
d69f01d to
47672f7
Compare
teodanciu
approved these changes
May 27, 2025
Soupstraw
force-pushed
the
jj/remove-shelley-tx-memo
branch
from
1a086d8 to
0744b28
Compare
Co-authored-by: Alexey Kuleshevich <[email protected]> Co-authored-by: teodanciu <[email protected]>
lehins
force-pushed
the
jj/remove-shelley-tx-memo
branch
from
0744b28 to
5478ff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #5033
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).