Skip to content

Parallelize #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Parallelize #1960

wants to merge 9 commits into from

Conversation

kderme
Copy link
Contributor

@kderme kderme commented Mar 21, 2025

Description

TODO:

  • the generated tx.id are wrong. They use block.id * 1000 + tx_index. However the genesis virtual block has more than 1000 txs, leading to duplicated. A cache could be used to get the last id for each block
  • soptEpochAndCacheEnabled is hardcoded False. Fix it/

Further improvements:

  • In function applyAndInsertBlocks we split the blocks based on byron or not. We should also split them for epochboundaries. To achieve this, we need to predict the slot details of the whole list of blocks, before the ledger application is done. This is possible since we can predict the slot details up to a specific horizon

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

Sorry, something went wrong.

kderme added 4 commits March 18, 2025 20:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kderme kderme force-pushed the kderme/parallelize branch from c024537 to 064aaf1 Compare March 24, 2025 10:43
@kderme kderme force-pushed the kderme/parallelize branch from ff015c7 to a6f18a4 Compare April 24, 2025 12:41
@kderme kderme force-pushed the kderme/parallelize branch from a6f18a4 to 7209d87 Compare April 25, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant