Skip to content

Add mnemonic sentence support #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Add mnemonic sentence support #975

merged 1 commit into from
Mar 21, 2025

Conversation

@palas
Copy link
Contributor

@palas palas commented Nov 20, 2024 •
edited
Loading

Changelog

- description: |
    Added support for mnemonic sentence generation and extended key derivation from mnemonic sentences.
  type:
  - feature

Context

This PR is associated to: IntersectMBO/cardano-api#678.
It is part of an effort to integrate cardano-addresses functionalities into the cardano-cli.

How to trust this PR

I would look mainly at the logic, the changes in the help golden files, and probably testing it is the best way.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Nov 20, 2024
@palas palas mentioned this pull request Nov 20, 2024
Merged
3 tasks
Jimbo4350
Jimbo4350 reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I want feedback from the rest of the team before we approve and merge.

carbolymer
carbolymer reviewed Nov 20, 2024
View reviewed changes
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jan 13, 2025
@palas palas removed the Stale label Jan 15, 2025
@palas palas mentioned this pull request Jan 31, 2025
Closed
@palas palas force-pushed the add-mnemonic-support branch from 9dd7301 to eab669b Compare February 12, 2025 18:27
Jimbo4350
Jimbo4350 reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I just have one concern regarding haskeline. If we don't need it lets not use it.

Jimbo4350
Jimbo4350 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 . One final question.

@palas palas force-pushed the add-mnemonic-support branch from 60eaa1c to 7c61f48 Compare February 20, 2025 13:23
@palas palas force-pushed the add-mnemonic-support branch from 7c61f48 to fca3c45 Compare March 21, 2025 19:02
@palas
Add support for generating mnemonics and deriving keys from mnemonics
5a25251 
- Add command to generate mnemonics
- Add commant to derive key from mnemonic
- Add support for writing and reading mnemonic from/to file
- Add interactive prompt for reading mnemonic
@palas palas force-pushed the add-mnemonic-support branch from fca3c45 to 5a25251 Compare March 21, 2025 19:09
@palas palas enabled auto-merge March 21, 2025 19:21
@palas palas added this pull request to the merge queue Mar 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2025
@palas palas added this pull request to the merge queue Mar 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2025
@palas palas added this pull request to the merge queue Mar 21, 2025
Merged via the queue into master with commit b38f750 Mar 21, 2025
25 of 26 checks passed
@palas palas deleted the add-mnemonic-support branch March 21, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer is a code owner

Assignees

@palas palas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add mnemonic support

4 participants

@palas @carbolymer @Jimbo4350