Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test adding certificates to a compatible transaction in Shelley era #1083

Closed

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Mar 7, 2025

Changelog

- description: |
    Test adding certificates to a compatible transaction in Shelley era
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Reproduction scenario for:

Needs

to make the test pass

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Sorry, something went wrong.

@carbolymer carbolymer self-assigned this Mar 7, 2025
@carbolymer carbolymer changed the title Fix missing certs in compatible transaction build Test adding certificates to compatible transaction in shelley era Mar 7, 2025
@carbolymer carbolymer force-pushed the mgalazyn/fix/compatible-tx-build-missing-certs branch from 7dd169c to 032876b Compare March 7, 2025 15:09
@carbolymer carbolymer changed the title Test adding certificates to compatible transaction in shelley era Test adding certificates to compatible transaction in Shelley era Mar 7, 2025
@carbolymer carbolymer marked this pull request as ready for review March 7, 2025 15:09
@carbolymer carbolymer changed the title Test adding certificates to compatible transaction in Shelley era Test adding certificates to a compatible transaction in Shelley era Mar 7, 2025
@carbolymer carbolymer force-pushed the mgalazyn/fix/compatible-tx-build-missing-certs branch from 032876b to be27487 Compare March 7, 2025 15:18
@carbolymer carbolymer force-pushed the mgalazyn/fix/compatible-tx-build-missing-certs branch from be27487 to 624edf8 Compare March 21, 2025 18:34
@carbolymer carbolymer enabled auto-merge March 21, 2025 18:34

Verified

This commit was signed with the committer’s verified signature.
carbolymer Mateusz Galazyn
…lley era
@carbolymer carbolymer force-pushed the mgalazyn/fix/compatible-tx-build-missing-certs branch from 624edf8 to b281aeb Compare March 24, 2025 17:54
@carbolymer
Copy link
Contributor Author

shelley support is already removed, this PR cannot be merged.

@carbolymer carbolymer closed this Apr 1, 2025
auto-merge was automatically disabled April 1, 2025 17:46

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The transaction signed-transaction command strips certificates from the Tx
2 participants