Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unicode mapping tables #440

Merged
merged 9 commits into from
Aug 28, 2021
Merged

Conversation

rmkaplan
Copy link
Contributor

This replaces the Unicode mapping tables for one-byte encodings (ISO8859-x) that John Cowan has indicated are obsolete. These new tables were downloaded from Unicode.

I also removed the EAST ASIAN tables, which John also reports are obsolete. The readme file points to the Unicode directory where current versions of those files can be obtained, and also a reference to a document that describes the format of those files.

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd rather not include Unicode files in the Medley source tree that say copyright (c) apple (especially ones of recent vintage.) If need be we can make another repo 'unicode-tables'.

And I would rather not have "obsolete" files if there isn't some justification for keeping them.

Are these files needed at run time? Are they used to create some Lisp code? Or tables? How are they used?

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Aug 27, 2021 via email

@masinter
Copy link
Member

masinter commented Aug 28, 2021

I think we should be more careful with copyright -- John was careful to mark copyright owners.
Our LICENSE file is per-repo. I'll want to check with our lawyer (once we have one), but I think anything Venue released. copyright Xerox or Fuji Xerox or Venue or Envos or JDS is OK in the Medley / Maiko repos which are marked MIT License.
I think (but will want to confirm) that LispUsers contributions are OK there.
Other things (especially recent files like outline fonts and unicode tables) may be available for download and distribution but under different license terms. If it is a problem, I'd rather make new repos called "unicode" and "fonts".

As far as obsolete goes, I'd like to drop the directory after confirming there isn't any use (the GATHER-INFO list of called-but-undefined used global but never set might help. But you know where you used the Unicode tables.

If you still want to keep them,, I'd prefer obsolete/pathto/file rather than pathto/obsolete/file since when I tar up files for release I can leave 'obsolete' behind.
I still don't know from the reply whether / which unicode files need to be part of the release.

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Aug 28, 2021 via email

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Aug 28, 2021 via email

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I misunderstood the origin of the "Obsolete" files.

@masinter masinter merged commit f5205e2 into master Aug 28, 2021
@rmkaplan
Copy link
Contributor Author

rmkaplan commented Aug 28, 2021 via email

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Aug 28, 2021 via email

@masinter masinter deleted the Update-Unicode-mapping-tables branch October 26, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants