Updates \ETHEREVENTFN to relocate exit when the ethernet is unvailable. #2418
Conversation
In the case that the ethernet is unavailable the \ETHEREVENTFN should still call \SETETHERFLAGS, \SETLOCALNSNUMBERS, and \FLUSHNDBS, or a newly started image will retain information from the system on which it was built (such as ethernet MAC address in the NS address). This will also ensure that the NS address is not set to 0, instead initializing with a fake address based on the system serial number (calls \SERIALNUMBER).
|
Fixes issue #2413 |
|
I'm running this branch on Linux Mint 22.1 Cinnamon and so far I haven't noticed anything unusual. |
|
Check \MY.NSADDRESS with the new and old Maiko in fresh sysouts, they should be different. |
|
What new Maiko? Isn't this change limited to Medley? |
|
Sorry, yeah, I haven't pushed that. You should still check \MY.NSADDRESS with the new Lisp code though. |
|
Under Medley/nhb-fix-ethereventfn and Maiko/master: |
|
Perfect, thanks. That's what I'd hoped we'd see. The .12345. is constant for a non-ethernet Medley, the 401 is coming from the "host serial number" (low 16 bits of the result of gethostid()). |
|
This PR should wait for an additional change -- I'd just make the change to the branch, but I'm having trouble getting a clean update to PUP. |
Probably should convert this PR to "Draft" until it's ready... |
In the case that the ethernet is unavailable the \ETHEREVENTFN should still call \SETETHERFLAGS, \SETLOCALNSNUMBERS, and \FLUSHNDBS, or a newly started image will retain information from the system on which it was built (such as ethernet MAC address in the NS address). This will also ensure that the NS address is not set to 0, instead initializing with a fake address based on the system serial number (calls \SERIALNUMBER).