Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHEELSCROLL: Put more of the branching logic inside the WHEELSCROLL function, add character names #2069

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

rmkaplan
Copy link
Contributor

Changes the function WHEELSCROLL so that the caller can pass a flag to specify the scrolling direction (positive or negative), and WHEELSCROLL decodes the parameters internally (also testing whether or not wheelscroll is enabled).

This is to allow an application(like Tedit) that runs with its own interrupts a simpler way of specifying the intended behavior.

I also introduced cHARACTERNAMES for the characters that wheelscroll uses to signal what should be done. This is to reduce dependency on the absolute values, so there is one less thing to worry about when we eventually move to Unicode.

I notice also that WHEELSCROLL is not incuded in the full.sysout. Is it time to include it by default?

@MattHeffron
Copy link
Contributor

I notice also that WHEELSCROLL is not incuded in the full.sysout. Is it time to include it by default?

It appears the it is already in full.sysout. I started full.sysout with no greet file, opened an Interlisp Exec, and entering PL WHEELSCROLL displayed the FILEDATES property, and the scrolling works fine.

@rmkaplan
Copy link
Contributor Author

Sorry, yes, it's there. I was looking in the XCL exec.

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per discussion in impl meeting

@masinter masinter merged commit 1bdaa63 into master Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants