Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GITFNS prc command #1994

Merged
merged 4 commits into from
Feb 3, 2025
Merged

fix GITFNS prc command #1994

merged 4 commits into from
Feb 3, 2025

Conversation

rmkaplan
Copy link
Contributor

I think I broke the non-menu single-PR case when I put in the JSON interface and the menu. prc of a string that matches a single PR should do that comparison without bringing up a menu. If it matches more than one, the menu should still come up. E.g prc rmk should bring up a menu of all my PRs.

@rmkaplan
Copy link
Contributor Author

Should fix #1991

@pamoroso
Copy link
Contributor

I tested this PR and now prc mth3--Extend-file-COPYRIGHT-for-succesive-owners drafts works as expected with no errors.

The PR fixes #1995 as discussed in #1991.

@pamoroso pamoroso linked an issue Jan 29, 2025 that may be closed by this pull request
Copy link
Contributor

@pamoroso pamoroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@masinter masinter merged commit fc36176 into master Feb 3, 2025
@masinter masinter deleted the rmk61--fix-prc-command branch February 3, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown branch error when calling GITFNS PRC with single branch
3 participants