Fix PRINT-ALL-DOCUMENTATION locating documentation string

[MattHeffron]

In PRINT-ALL-DOCUMENTATION only one of two places was checked for the documentation string.
(Also, MAKEFILE updated the LAMA variable in the CMLEXECCOMS.)
Issue #1735

[rmkaplan]

In the technical meeting today, we focused on the LAMA specification in the files COMS. It seems very odd (as in I have never seen it) that a file has explicit settings for the LAMA, NLAMA... variables, those were always automatically supplied and properly updated by the MAKEFILE.

Is there something special about this particular file? Or are these variable settings just a historical mistake that is being carried forward. What would happen if this command is simply removed from the file?

(We noted that this file is compiled by FAKE-COMPILE-FILE, if that is somehow relevant to this question.)

[MattHeffron]

@rmkaplan The changes to LAMA are the subject of my Issue #1725.
In this case, instead of having the file contain two instances of the COMS; the original, and the one updated by the MAKEFILE, I did a few steps:

1. I saved the file with MAKEFILE writing the COMS twice.
2. I exited the sysout and started a clean FULL sysout.
3. I loaded the file 'PROP (At this point the COMS were updated.)
4. I marked PRINT-ALL-DOCUMENTATION as changed.
5. I did a CLEANUP of the file. (Only the single, updated, COMS are written.)
6. Created the Pull request.

[MattHeffron]

I don't know if removing the

(DECLARE%: DONTEVAL@LOAD DOEVAL@COMPILE DONTCOPY COMPILERVARS 
(ADDTOVAR NLAMA DIR)
(ADDTOVAR NLAML )
(ADDTOVAR LAMA PROCESS-EXEC-ID PRINT-EVENT PRINT-HISTORY EXEC-PRIN1 EVENTS-INPUT EVAL-INPUT EXEC-READ)
)

from the COMS would have any effect, good or bad. It seems simplest just to leave it and include MAKEFILE's update.

[rmkaplan]

It does seem that MAKEFILE adds/updates these commands automatically as needed in all the managed files, so I think leaving them is the right thing to do.

…

On May 30, 2024, at 5:25 PM, Matt Heffron ***@***.***> wrote: I don't know if removing the (DECLARE%: ***@***.*** ***@***.*** DONTCOPY COMPILERVARS (ADDTOVAR NLAMA DIR) (ADDTOVAR NLAML ) (ADDTOVAR LAMA PROCESS-EXEC-ID PRINT-EVENT PRINT-HISTORY EXEC-PRIN1 EVENTS-INPUT EVAL-INPUT EXEC-READ) ) from the COMS would have any effect, good or bad. It seems simplest just to leave it and include MAKEFILE's update. — Reply to this email directly, view it on GitHub <#1736 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJKQI37F7JK5FOAGDYLZE67PTAVCNFSM6AAAAABIISDJPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGA2DANJZHE>. You are receiving this because you were mentioned.

[fghalasz]

Approved as per Implementors Mtg on 2024-06-03