-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the non-keypad arrow keys to be detected. #531
Conversation
With additional Medley calls to KEYACTION (below), they should work in TTYIN (i.e., XCL and Interlisp EXECs). I didn't try TEDIT. They are unrecognized in SEDIT. (In any case, their use there probably is pretty restricted by the nature of SEDIT.) (KEYACTION 'KEYPAD8 '(("Meta,^" 56 NOLOCKSHIFT) . IGNORE)) (KEYACTION 'KEYPAD6 '(("Meta,>" 54 NOLOCKSHIFT) . IGNORE)) (KEYACTION 'KEYPAD4 '(("Meta,<" 52 NOLOCKSHIFT) . IGNORE)) (KEYACTION 'KEYPAD2 '(("Meta,^J" 50 NOLOCKSHIFT) . IGNORE))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beyond marvelous!
The patch works surprisingly well with Medley VNC and my Italian keyboard on Linux. In an Exec I can use all the arrow keys (both keypad and non keypad) to move the caret in any direction to any part of the input text, including immediately to the right of the rightmost character on a line.
In TEdit I can move left and right with both keypad groups but not up and down, which is understandable. However, if I start in the middle of the text on a line and keep moving right, the caret stops immediately before the rightmost character and does not proceed further. For example, if I start with the caret as indicated in this line:
abcde^fghijk
and keep pressing the right arrow the caret stops as shown here:
abcdefghij^k
Now, If only I could type <
...
The left and right arrow keys work also in the prompt area of TEdit and the File Browser. I can move the caret to the right of the rightmost character. |
Presumably the KEYACTION expressions should go into LLKEY ? |
The KEYACTION expressions should go on the MAIKOKEYACTIONS list in LLKEY. This should not have been merged without a proper review. |
And it should probably be checking for it being an X keyboard type before adding these keyactions. There's code that looks for it being a Sun type 4 keyboard in the DEVCONFIG of the Interface page (we've got 3 bits there for keyboard types) and we probably want something similar. I'll look at the Maiko initialization of that field. |
I confirm this change works on Linux under X also without VNC. |
That would be a PR in Medley, not maiko. In a sense, they are independent. |
Yes, that's a MEDLEY PR for the KEYACTIONS. @MattHeffron - are you planning on taking over maintenance of the maiko code? If not, please wait for my review before merging changes. |
(X11 in WSL Ubuntu 22.04 on Windows 11.)
With additional Medley calls to
KEYACTION
(below), they should work inTTYIN
(i.e., XCL and Interlisp EXECs).I didn't try
TEDIT
.They are unrecognized in
SEDIT
. (In any case, their use there probably is pretty restricted by the nature of SEDIT.)These
KEYACTION
calls also seems to make these work for the Keypad arrow keys.