Skip to content

Replaces shadowed "-t <interval>" with "-timer <interval>" #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

nbriggs
Copy link
Collaborator

@nbriggs nbriggs commented Dec 17, 2024

At some point option "-t" was introduced as an abbreviation for "-title" but "-t" was already in use, though undocumented, for overriding the timer interval. This commit changes the command line timer option to "-timer" and adds "timer" to the options that are processed from the X11 resources.

At some point option "-t" was introduced as an abbreviation for
"-title" but "-t" was already in use, though undocumented, for overriding
the timer interval.  This commit changes the command line timer option
to "-timer" and adds "timer" to the options that are processed from
the X11 resources.
@nbriggs nbriggs merged commit e6c972a into master Dec 17, 2024
@masinter
Copy link
Member

the handling of lde call parameters vs. the ones to the scripts/medley parameters confuses me.
Should anyone be still using the "run-medley" shell script? Maybe allow --timer as well as -timer if you want consistency?

@nbriggs
Copy link
Collaborator Author

nbriggs commented Dec 19, 2024

I use run-medley. I don't use "medley.sh" (?). The scripts to drive lde started at PARC and continued as they have here, for similar reasons -- people wanted shortcuts so it mostly did the right thing without having to think about it -- but we've been changing the script options to spell them differently (e.g., double-dash-long-option instead of dash-long-option and dash-short-option, with new names) because people don't like the old option names (or didn't know what old options there were so they invented new ones).

The lde options provide all the knobs for the low level things that the higher level scripts may make coordinated changes to (e.g., "-id foo" sets up the window title as "foo", and sets up the LDESRCSYSOUT/LDEDESTSYSOUT environment variables to "~/lisp/lisp-foo.virtualmem", and so on...)

We could make a breaking change and switch to all "--foo" options on lde/ldex/ldesdl/ldeether, but I'm not exactly sure what that buys us, except for either breaking the X11 standard option parsing, which has builtin options (like "-geometry") or having mixed use of dash and double-dash options.

So... for this case, I just made the expedient fix that meant that if we wanted to experiment with the timer frequency, we didn't have to edit the source and recompile maiko because the only timer option was shadowed by the short form title option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants