Fix display bitmap flushing on modification when using SDL display subsystem #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the target for a PILOTBITBLT operation is the display bitmap, and the display bitmap is not memory-mapped from the actual display, the display subsystem needs to be notified to flush the Lisp display bitmap to the display so that changes are immediately visible. The mechanism was present for X11 displays but needed to be implemented for SDL displays.
Two problems fixed: * only in the case of a software cursor is it necessary to check if the bit being altered is within the region of the display covered by the cursor, and if it is, the cursor must be hidden before operating on the screen bitmap * SDL as well as X requires modifications to the screen bitmap be flushed to the actual display.
|
I just pulled the branch, built maiko SDL, and resumed the virtual memory image I had used to create the test case. Now Nice! Thanks for the quick fix, @nbriggs. @abhikhasnain1, once this is merged you should get a new Maiko and run with that. Let us know if you need help with that. |
|
@hjellinek do you want to "officially" review/approve before I merge it, or should I just take the comment above as approval. |
hjellinek
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue Interlisp/medley#1908
In cases where the target of a
PILOTBITBLTopcode, or the target of anFBITMAPBITopcode, is the display bitmap, the SDL display subsystem needs to be notified of the "damage" so that the real display can be updated.Slightly Improves performance for
FBITMAPBITin case where there is no soft cursor that would need to be taken down before accessing the screen bitmap.