Fix #1826 - emulator crash when too many versions of a file in a directory #512
+29
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory This is a preliminary fix to avoid a system crash (bus error/seg fault) when operating on a file with too many versions present in the directory. Initial fix is to report an error (EIO, SIMPLE-DEVICE-ERROR) when doing an operation that would result in an out-of-bounds access in the emulator.
nbriggs
requested review from
masinter,
hjellinek,
MattHeffron and
rmkaplan
nbriggs
commented
Sep 16, 2024
There was a problem hiding this comment.
@MattHeffron - I read through the DOS part again, and I believe it is correct.
At the only point where it increments the varray_index value it checks that it remains within bounds, and the last value that it takes on (and no greater) will be used to access the array at that index when the loop exits. If the value goes out of range - well, that's where I have no idea how to report the value upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary fix to avoid a system crash (bus error/seg fault) when operating on a file with too many versions present in the directory.
Reports an error (EIO, SIMPLE-DEVICE-ERROR) when doing an operation that would result in an out-of-bounds access in the emulator.
A better fix would be to dynamically allocate the necessary version storage, but that will
take longer to work out.
Test environment is a directory that contains over 200 versions of a file and you attempt to do a create (new version) or delete operation on the file.