Release 201 corrections #510
Merged
+73
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 201 does not have BIGVM, so SWA_FNHEAD requires swapx which is defined in byteswapdefs.h
Version 201 did not have NEWCDRCODING, so the implementation of N_OP_rplcons requires definitions from gcdata.h and address.h
…rsions The makeright script and the makefile-* slices it depends are modified to allow easily specifying the RELEASE version number of the Maiko emulator to be built. The default version remains 351, but can be changed with e.g. RELEASE=201 ./makeright x The object directories and executables are NOT named with the version.
…e gcdata.h macros
…pendence on GCENTRY size differences between releases
|
It would be useful to have some notes on the new build options, for example by copying this PR's description to the Maiko README. |
|
A complete update of the README.md would be good. There's no SDL, Networking, or CMake info there either. However, building for an old release is not (yet) interesting for anyone who isn't pretty familiar with the history of Medley releases, the various changes that the different versions implied (big atoms, bigvm, bigbigvm, etc.) and helping debug the Maiko code. |
masinter
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrections to code and improvements to build infrastructure to enable building older releases of Maiko compatible with older Medley sysouts.
makerightwill use the value of the environment variableRELEASEto select the version to build (default current, 351)CMakeoptionMAIKO_RELEASEselects the version to build if using that tool (default current, 351)modify_big_reference_countto reflect that the size of a GC table entry depended on the version.The build artifacts and directories do NOT include the release version number, so be careful to clean before building. An enhancement here could be to add the version for non-current build directories and executable names.
While the code now compiles, attempting to run an older (2.0) sysout does not work, so more investigation and fixes remain to be done.