Add a global lua api to serve version helper functions #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsions from our addons. Also removed old unused IMC event
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
zyxkad
reviewed
May 6, 2025
src/main/java/de/srendi/advancedperipherals/common/addons/APAddons.java
Outdated
Show resolved
Hide resolved
zyxkad
reviewed
May 6, 2025
...java/de/srendi/advancedperipherals/common/addons/computercraft/luaapi/GlobalAPHelperAPI.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Z <[email protected]> Signed-off-by: Srendi <[email protected]>
zyxkad
reviewed
May 7, 2025
...java/de/srendi/advancedperipherals/common/addons/computercraft/luaapi/GlobalAPHelperAPI.java
Outdated
Show resolved
Hide resolved
zyxkad
reviewed
May 8, 2025
| @@ -50,7 +50,7 @@ public class CCRegistration { | |||
|
|
|||
| public static void register() { | |||
| IntegrationPeripheralProvider.load(); | |||
| ComputerCraftAPI.registerAPIFactory(unused -> new GlobalAPHelperAPI()); | |||
| ComputerCraftAPI.registerAPIFactory(unused -> new GlobalVersionsLuaAPI()); | |||
There was a problem hiding this comment.
since it's not related to computer environment, we can also use singleton for it.
Suggested change
| ComputerCraftAPI.registerAPIFactory(unused -> new GlobalVersionsLuaAPI()); | |
| ComputerCraftAPI.registerAPIFactory(unused -> GlobalVersionsLuaAPI.INSTANCE); |
zyxkad
reviewed
May 8, 2025
| @@ -13,12 +13,9 @@ | |||
| import java.util.Map; | |||
| import java.util.Optional; | |||
|
|
|||
| public class GlobalAPHelperAPI implements ILuaAPI { | |||
| public class GlobalVersionsLuaAPI implements ILuaAPI { | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| public static final String INSTANCE = new GlobalVersionsLuaAPI(); | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new global accessible lua api (to every computer, turtle and pocket) to serve helper functions to retrieve versions of AP, MC and our add-ons
I primarily had this idea when I made the new bridges and 0.8 to check if a script even supports your AP version.