Skip to content

fix warnings generated at compile time #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix warnings generated at compile time #69

wants to merge 4 commits into from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 29, 2025

This PR fixes two warnings:

  1. prec-sqrt option is removed since it is not anymore supported by icx.
warning message These options as listed are not supported. For more information, use '-qnextgen-diag'. option list: -prec-sqrt
  1. [-Warray-bounds] warning
warning message $SRC_DIR/mkl_umath/src/mkl_umath_loops.c.src:246:9: warning: the pointer incremented by 9223372036854775807 refers past the last possible element for an array in 64-bit address space containing 32-bit (4-byte) elements (max possible 4611686018427387904 elements) [-Warray-bounds] 246 | CHUNKED_VML_CALL2(vsSqrt, dimensions[0], npy_float, args[0], args[1]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ $SRC_DIR/mkl_umath/src/mkl_umath_loops.c.src:85:13: note: expanded from macro 'CHUNKED_VML_CALL2' 85 | in1p += _chunk_size; \ | ^ ~~~~~~~~~~~

$SRC_DIR/mkl_umath/src/mkl_umath_loops.c.src:127:13: note: expanded from macro 'CHUNKED_VML_LINEARFRAC_CALL'
127 | op1p += _chunk_size;
| ^ ~~~~~~~~~~~
$SRC_DIR/mkl_umath/src/mkl_umath_loops.c.src:1352:70: note: array 'op1p' declared here
1352 | CHUNKED_VML_LINEARFRAC_CALL(vdLinearFrac, dimensions[0], npy_double, args[0], args[2], 1.0, (npy_double)args[1], 0.0, 1.0);
| ^
$SRC_DIR/mkl_umath/src/mkl_umath_loops.c.src:1427:13: warning: the pointer incremented by 9223372036854775807 refers past the last possible element for an array in 64-bit address space containing 64-bit (8-byte) elements (max possible 2305843009213693952 elements) [-Warray-bounds]
1427 | CHUNKED_VML_CALL3(vdSub, dimensions[0], npy_double, args[0], args[1], args[2]);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$SRC_DIR/mkl_umath/src/mkl_umath_loops.c.src:103:13: note: expanded from macro 'CHUNKED_VML_CALL3'
103 | in1p += _chunk_size;
| ^ ~~~~~~~~~~~

@vtavana vtavana self-assigned this Apr 29, 2025
@vtavana vtavana marked this pull request as ready for review April 29, 2025 23:01
@@ -82,7 +81,6 @@ elseif(UNIX)
"${SDL_FLAGS}"
)
string(CONCAT PRECISION_FLAGS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were used previously with icc compiler. And they were kept during migration to icx since otherwise some tests are failing due to the precision issue.
But from the description of imf-precision=high option it sounds like it covers prec-sqrt and so it should be fine to remove that one rather than finding the replacement alternative.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know the tests which would fail? We can verify that this change won't reintroduce the failures

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be some scope in the internal CI. Hope @ekomarova can provide more insights on that.

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM! Thank you @vtavana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants